fix: Complete themes are valid add-ons #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
commented
Jun 28, 2017
| className="Addon-theme-header" | ||
| id="Addon-theme-header" | ||
| data-browsertheme={getBrowserThemeData()} | ||
| ref={(el) => { this.wrapper = el; }} |
There was a problem hiding this comment.
This was unused and caused a non-100% coverage error so I deleted it. I know it's unrelated but figured it was worth it.
kumar303
approved these changes
Jun 28, 2017
src/core/constants.js
Outdated
| export const ADDON_TYPE_LANG = 'language'; | ||
| export const ADDON_TYPE_OPENSEARCH = 'search'; | ||
| export const ADDON_TYPE_THEME = 'persona'; | ||
| export const ADDON_TYPE_CLASSIC_THEME = 'theme'; |
There was a problem hiding this comment.
can we just call this ADDON_TYPE_COMPLETE_THEME?
src/core/constants.js
Outdated
| export const ADDON_TYPE_THEME = 'persona'; | ||
| export const ADDON_TYPE_CLASSIC_THEME = 'theme'; | ||
| export const validAddonTypes = [ | ||
| ADDON_TYPE_CLASSIC_THEME, // Remove once we don't support complete themes. |
There was a problem hiding this comment.
One day we might start grepping TODO so it would probably make sense to add that to the comment so we don't forget
tofumatt
force-pushed
the
rating-manager-login-error
branch
from
117047e to
af319f1
Compare
tofumatt
force-pushed
the
rating-manager-login-error
branch
from
af319f1 to
7a41631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#10507.