Skip to content

fix: Complete themes are valid add-ons #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2017
Merged

fix: Complete themes are valid add-ons #2648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/amo/components/Addon/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ export class AddonBase extends React.Component {
className="Addon-theme-header"
id="Addon-theme-header"
data-browsertheme={getBrowserThemeData()}
ref={(el) => { this.wrapper = el; }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused and caused a non-100% coverage error so I deleted it. I know it's unrelated but figured it was worth it.

onClick={this.onClick}
>
{installStatus !== ENABLED ? (
Expand Down
4 changes: 4 additions & 0 deletions src/core/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ export const ADDON_TYPE_EXTENSION = 'extension';
export const ADDON_TYPE_LANG = 'language';
export const ADDON_TYPE_OPENSEARCH = 'search';
export const ADDON_TYPE_THEME = 'persona';
// TODO: Remove ADDON_TYPE_COMPLETE_THEME once we don't support complete
// themes.
export const ADDON_TYPE_COMPLETE_THEME = 'theme';
export const validAddonTypes = [
ADDON_TYPE_COMPLETE_THEME,
ADDON_TYPE_DICT,
ADDON_TYPE_EXTENSION,
ADDON_TYPE_LANG,
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/core/reducers/test_categories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
ADDON_TYPE_COMPLETE_THEME,
ADDON_TYPE_DICT,
ADDON_TYPE_EXTENSION,
ADDON_TYPE_LANG,
Expand Down Expand Up @@ -175,6 +176,7 @@ describe('categories reducer', () => {
// https://github.com/mozilla/addons-server/issues/4766 is fixed.
expect(state.categories).toEqual({
firefox: {
[ADDON_TYPE_COMPLETE_THEME]: {},
[ADDON_TYPE_DICT]: {},
[ADDON_TYPE_EXTENSION]: {
'alert-update': {
Expand Down Expand Up @@ -214,6 +216,7 @@ describe('categories reducer', () => {
},
},
android: {
[ADDON_TYPE_COMPLETE_THEME]: {},
[ADDON_TYPE_DICT]: {},
[ADDON_TYPE_EXTENSION]: {
'alert-update': {
Expand Down