Add merge locale script #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muffinresearch
force-pushed
the
add-merge-locale-script
branch
from
329e98a to
6d344bd
Compare
|
I added a new string in #475 that we should localise. I'm assuming we need this to extract again now that we've got some translations? Looks good but I haven't tried it out. r+ |
bin/merge-locales
Outdated
| const dir = path.dirname(poFile); | ||
| const stem = path.basename(poFile, '.po'); | ||
| const tempFile = path.join(dir, `${stem}.po.tmp`); | ||
| const poFilePath = path.join(dir, `${stem}.po`); |
There was a problem hiding this comment.
Actually I think this is the same as poFile?
There was a problem hiding this comment.
Good catch, thanks!
muffinresearch
force-pushed
the
add-merge-locale-script
branch
from
6d344bd to
8fbc6ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9622