Fetch results from the API #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| <div | ||
| ref="editorialDescription" | ||
| className="editorial-description" | ||
| dangerouslySetInnerHTML={sanitizeHTML(description, ['blockquote', 'cite'])} /> |
There was a problem hiding this comment.
Would be nice to have some tests just to prove this is working as we expect. E.g. just in-case a later lib update changed something etc.
There was a problem hiding this comment.
Ah, yes. We had discussed that but I forgot about it. Thanks!
|
r+wc with some tests added to directly cover the purification step. |
|
Excited by this, thanks @mstriemer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a bug where the icon doesn't go away on uninstall. This was working previously so I'm not sure what changed. It's definitely uninstalled...
Fixes mozilla/addons#9610.