Skip to content

still have a link in the queue for addons that have an empty name #21167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

still have a link in the queue for addons that have an empty name #21167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/olympia/reviewers/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1526,6 +1526,25 @@ def test_queue_layout(self):
'🛠️ Manual Review', tab_position=0, total_addons=4, total_queues=2
)

def test_empty_name(self):
self.get_expected_addons_by_names(
['Nominated One'],
auto_approve_disabled=True,
)
addon = self.addons['Nominated One']
addon.name = ' '
addon.save()

response = self.client.get(self.url)

url = reverse('reviewers.review', args=[addon.pk])
doc = pq(response.content)
links = doc('#addon-queue tr.addon-row td a:not(.app-icon)')
a_href = links.eq(0)

assert a_href.text() == f'[{addon.id}] 0.1'
assert a_href.attr('href') == url

def test_webextension_with_auto_approval_disabled_false_filtered_out(self):
self.generate_files(auto_approve_disabled=True)
self.addons['Pending Two'].reviewerflags.update(auto_approval_disabled=False)
Expand Down
11 changes: 5 additions & 6 deletions src/olympia/reviewers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ def is_admin_reviewer(user):


class AddonQueueTable(tables.Table):
addon_name = tables.Column(verbose_name='Add-on', accessor='name', orderable=False)
addon_name = tables.Column(
verbose_name='Add-on', accessor='name', orderable=False, empty_values=()
)
# Override empty_values for flags so that they can be displayed even if the
# model does not have a flags attribute.
flags = tables.Column(verbose_name='Flags', empty_values=(), orderable=False)
Expand Down Expand Up @@ -106,13 +108,10 @@ def _get_addon_name_url(self, record):

def render_addon_name(self, record):
url = self._get_addon_name_url(record)
name = markupsafe.escape(str(record.name or '').strip() or f'[{record.id}]')
return markupsafe.Markup(
'<a href="%s">%s <em>%s</em></a>'
% (
url,
markupsafe.escape(record.name),
markupsafe.escape(self.get_version(record).version),
)
% (url, name, markupsafe.escape(self.get_version(record).version))
)

def render_last_human_review(self, value):
Expand Down