Fix Bug 836462 - Move Thunderbird landing page to Bedrock #3217

kyoshino · 2015-08-18T08:05:46Z

A screenshot can be found in the bug.
Imported the localized strings from html to lang files in r145109 using a script.

flodolo · 2015-08-18T19:02:17Z

.lang files are now tracked, and pushed on stage and prod. Also added en-US reference file, and some locales that ship with Thunderbird and were not covered by the import

schalkneethling · 2015-08-19T10:51:14Z

One thing I have noticed so far:

The wrapper should not be sized down as it is here because it throws of the alignment of Tabzilla. Instead I would suggest tweaking the width of the main container for the mobile view/layout.

Perhaps something like:

@media only screen and (max-width: 760px) {
  #wrapper {
    width: 100%;
    padding: 0;
  }
 #main-feature {
    margin: 20px auto 40px;
    padding: 0 10px;
   max-width: 600px;
  }

schalkneethling · 2015-08-19T10:53:02Z

That will then probably also require some tweaks to the footer.

schalkneethling · 2015-08-19T11:04:54Z

bedrock/security/templates/security/bug-bounty/faq.html

@@ -190,10 +190,7 @@ <h1 itemprop="name" class="title-shadow-box">Bug Bounty Program FAQ</h1>
            the system requirements for the


The "the" in this sentence is incorrect but, it is already out there so, not sure if we can remove it at this point.

Removed the extra "the". Should be okay because the change is trivial and this page is not localized.

kyoshino · 2015-08-19T22:13:15Z

Thanks @schalkneethling, looks like the wrapper issue is site-wide. The Firefox landing page has the same bug. We could fix it in a follow-up PR to improve the mobile landscape layout.

schalkneethling · 2015-08-20T17:36:38Z

media/css/thunderbird/landing.less

+    background: -ms-radial-gradient(center, ellipse cover,  rgba(234,239,242,1) 0%, rgba(212,221,228,.5) 60%),
+                -ms-linear-gradient(top, rgba(202,225,244,1) 0%, rgba(125,185,232,0) 100%);
+    background: radial-gradient(ellipse at center, rgba(234,239,242,1) 0%,rgba(212,221,228,.5) 50%),
+                linear-gradient(to bottom, rgba(202,225,244,1) 0%,rgba(125,185,232,0) 100%);


You should probably use the gradient mixins here: https://github.com/mozilla/bedrock/blob/master/media/css/sandstone/lib.less#L290

Hm, I just copied and pasted that part from firefox/landing.css. It's a little bit complex so we cannot use the mixin I guess...

Perhaps that is the case. I reckon it is ok for now. The one thing I will not is that there is currently a bug to remove the use of -moz- prefix for gradients [https://bugzilla.mozilla.org/show_bug.cgi?id=1189121] so, perhaps remove those here as part of this PR.

Remove the -moz-prefixed gradients.

jpetto · 2015-08-20T22:12:02Z

This, along with the other Thunderbird related PRs, is currently up on demo4: https://www-demo4.allizom.org/en-US/thunderbird/

schalkneethling · 2015-08-21T11:58:20Z

Tested on Fx, Chrome, Safari and IE. Other than the comment regarding removing the -moz- prefix, this looks good to me. Great stuff @kyoshino r+

schalkneethling · 2015-08-21T11:58:49Z

@jpetto If there is nothing else you have picked up, I reckon we are good to merge this one.

jpetto · 2015-08-21T14:32:54Z

bedrock/thunderbird/helpers.py

+    :param ctx: context from calling template.
+    :param channel: name of channel: 'release', 'beta' or 'alpha'.
+    :param small: Display the small button if True.
+    :param icon: Display the Fx icon on the button if True.


Doesn't look like this is supported at the moment, so maybe remove or comment out this param for now?

Removed the icon param.

jpetto · 2015-08-21T14:44:55Z

Should run the images through a compressor. I did a quick test with ImageAlpha/ImageOptim combo and saved over 50% on the screenshots.

jpetto · 2015-08-21T14:46:19Z

I hate bringing up old IE issues, but IE 7 is a bit broken:

Not sure how much this matters, but it looks like it might be an easy fix.

schalkneethling · 2015-08-21T16:08:40Z

Ooooh @jpetto Good catch, I did not test IE7 to be honest, IE8+ only.

kyoshino · 2015-08-21T23:05:20Z

Fixed the odd IE7 layout and optimized the images with ImageAlpha.

kyoshino · 2015-08-23T06:02:08Z

Added localized images. (optimized)

schalkneethling · 2015-08-24T09:39:37Z

Tested in IE7, all looks good. @jpetto you happy?

jpetto · 2015-08-24T16:04:17Z

Looking good to me. Pinging @pmclanahan to double check the Python bits.

pmclanahan · 2015-08-24T17:42:24Z

I think the Python looks good. I'd like for there to be tests for the new download_thunderbird helper, and they can likely be mostly copied from the Firefox one. Other than that I seems about ready.

kyoshino · 2015-08-24T18:29:48Z

Thanks @pmclanahan. As I wrote above, the helper is partially broken because we don't have the Earlybird data in product-details. For the Release channel, it should be no problem. I'll implement a workaround and add tests for that in the upcoming PR for the channel and all-beta page migration.

schalkneethling · 2015-08-24T18:53:20Z

@pmclanahan r?

jpetto · 2015-08-24T20:03:01Z

If tests are coming in one of the other Thunderbird PRs, then I think we're good to merge?

pmclanahan · 2015-08-25T02:13:51Z

That still leaves us with a completely untested download button for a product. It just makes me nervous. I'm sure it's better than the old PHP one, but can we at least add tests that verify that the things we expect it to do right now work?

kyoshino · 2015-08-25T06:55:49Z

Added tests! Beta and Earlybird are out of the coverage for now, but this is better than nothing, as @pmclanahan said. r?

pmclanahan · 2015-08-25T14:54:31Z

Thanks @kyoshino! Let's ship it r+

schalkneethling · 2015-08-25T15:24:16Z

Manually merged: 33a5ff3

schalkneethling reviewed Aug 19, 2015
View reviewed changes

schalkneethling reviewed Aug 20, 2015
View reviewed changes

jpetto reviewed Aug 21, 2015
View reviewed changes

kyoshino added 2 commits August 25, 2015 02:39

Fix Bug 836462 - Move Thunderbird landing page to Bedrock

2493884

Fix Bug 1197065 - Localize Thunderbird landing page screenshot

21f9652

schalkneethling closed this Aug 25, 2015

kyoshino deleted the bug-836462-port-tb-landing branch August 29, 2015 14:48

kyoshino mentioned this pull request Aug 29, 2015

Fix Bug 1199916 - Make image helpers always work without img prefix #3262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Bug 836462 - Move Thunderbird landing page to Bedrock #3217

Fix Bug 836462 - Move Thunderbird landing page to Bedrock #3217

kyoshino commented Aug 18, 2015

flodolo commented Aug 18, 2015

schalkneethling commented Aug 19, 2015

schalkneethling commented Aug 19, 2015

schalkneethling Aug 19, 2015

kyoshino Aug 19, 2015

kyoshino commented Aug 19, 2015

schalkneethling Aug 20, 2015

kyoshino Aug 20, 2015

schalkneethling Aug 21, 2015

kyoshino Aug 21, 2015

jpetto commented Aug 20, 2015

schalkneethling commented Aug 21, 2015

schalkneethling commented Aug 21, 2015

jpetto Aug 21, 2015

kyoshino Aug 21, 2015

jpetto commented Aug 21, 2015

jpetto commented Aug 21, 2015

schalkneethling commented Aug 21, 2015

kyoshino commented Aug 21, 2015

kyoshino commented Aug 23, 2015

schalkneethling commented Aug 24, 2015

jpetto commented Aug 24, 2015

pmclanahan commented Aug 24, 2015

kyoshino commented Aug 24, 2015

schalkneethling commented Aug 24, 2015

jpetto commented Aug 24, 2015

pmclanahan commented Aug 25, 2015

kyoshino commented Aug 25, 2015

pmclanahan commented Aug 25, 2015

schalkneethling commented Aug 25, 2015

		@@ -190,10 +190,7 @@ <h1 itemprop="name" class="title-shadow-box">Bug Bounty Program FAQ</h1>
		the system requirements for the

Fix Bug 836462 - Move Thunderbird landing page to Bedrock #3217

Fix Bug 836462 - Move Thunderbird landing page to Bedrock #3217

Conversation

kyoshino commented Aug 18, 2015

flodolo commented Aug 18, 2015

schalkneethling commented Aug 19, 2015

schalkneethling commented Aug 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kyoshino commented Aug 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpetto commented Aug 20, 2015

schalkneethling commented Aug 21, 2015

schalkneethling commented Aug 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpetto commented Aug 21, 2015

jpetto commented Aug 21, 2015

schalkneethling commented Aug 21, 2015

kyoshino commented Aug 21, 2015

kyoshino commented Aug 23, 2015

schalkneethling commented Aug 24, 2015

jpetto commented Aug 24, 2015

pmclanahan commented Aug 24, 2015

kyoshino commented Aug 24, 2015

schalkneethling commented Aug 24, 2015

jpetto commented Aug 24, 2015

pmclanahan commented Aug 25, 2015

kyoshino commented Aug 25, 2015

pmclanahan commented Aug 25, 2015

schalkneethling commented Aug 25, 2015