Fix Bug 1199916 - Make image helpers always work without img prefix #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoshino
changed the title
|
This makes sense to me and is a couple less characters to type ;p I am going to leave this open for comment by other @jpetto @alexgibson etc. If this is going to get merged, we will have to update the relevant docs here: http://bedrock.readthedocs.org/en/latest/coding.html#embedding-images Thanks! |
|
|
|
As other image helpers are implicitly aware of the top level r+ from me. Pinging @pmclanahan to double-check the Python side of things. |
pmclanahan
pushed a commit
that referenced
this pull request
Aug 31, 2015
Fix Bug 1199916 - Make image helpers always work without img prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the second commit in #3217 for why this should be fixed.