This repository was archived by the owner on May 10, 2019. It is now read-only.
Prefetch dialog components from the communication_iframe #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the browser is idle, it will start fetching and caching the dialog's Javascript, CSS and images. This works on IE9 and Firefox (it's currently disabled in Chromium). The trick is to make sure that the communication iframe is open while the user is busy reading the RP's site. When using the Observer API, this happens automatically at the end of the navigator.id.watch() call.
Contributor
Author
|
I also thought it might be a good idea to add a new helper function to connect-cachify. In which case we could make this patch a bit more readable: fmarier@e78a8a6 |
ghost
assigned
Member
|
do we want to pull in this optimization? @shane-tomlinson, @fmarier, thoughts? let's close this if we don't want to pull this code in right now, so that we can get to PR inbox zero (theoretically at least). |
|
@6a68 - not yet, not until we slim down the overall bundle. |
Contributor
Author
|
I'll submit a new pull request once we're ready to merge. I have to simplify this one anyways since Austin merged my connect-cachify PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser is idle, it will start fetching and caching the dialog's Javascript, CSS and images. This works on IE9 and Firefox
(it's currently disabled in Chromium).
The trick is to make sure that the communication iframe is open while the user is busy reading the RP's site. When using the
Observer API, this happens automatically at the end of the navigator.id.watch() call.
More background on this feature here: http://feeding.cloud.geek.nz/2012/11/prefetching-resources-to-prime-browser.html