fix(functional-test): update failing coupon tests #16983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mozilla-fxa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Trinaa
reviewed
May 22, 2024
| await expect( | ||
| await subscribe.getCouponStatusByDataTestId('coupon-error') | ||
| ).toBeVisible({ | ||
| timeout: 5000, |
There was a problem hiding this comment.
I think this timeout may be redundant?
When timeout is defined here I think it overrides the TestConfig.expect value, which is defaulted to 5000ms
Comment on lines
36
to
37
| expect(await subscribe.couponErrorMessageText()).toContain( | ||
| 'The code you entered has expired' |
There was a problem hiding this comment.
I'm wondering if we would get more reliable performance if we made this an auto-awaited assert that is user-facing.
await expect(page.getByText('The code you entered has expired')).toBeVisible();
Comment on lines
+14
to
+16
| async getCouponStatusByDataTestId(dataTestId: string) { | ||
| return this.page.locator(`[data-testid="${dataTestId}"]`); | ||
| } |
There was a problem hiding this comment.
Playwright recommends using built-in locators, applying that recommendation + standardizing the use of accessors in page objects would look like:
get couponError() {
return this.page.getByTestId('coupon-error');
}
get removeCouponButton() {
return this.page.getByTestId('coupon-remove-button');
}
4 tasks
sardesam
pushed a commit
that referenced
this pull request
May 22, 2024
Because: * We want to reduce our failure rate on tests. This commit: * Re-adds fixmes removed in #16983.
4 tasks
chenba
pushed a commit
that referenced
this pull request
May 24, 2024
Because: * We want to reduce our failure rate on tests. This commit: * Re-adds fixmes removed in #16983.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
fixmeannotation.data-test-idIssue that this pull request solves
Closes FXA-9689
Checklist
Put an
xin the boxes that apply