Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(functional-test): update failing coupon tests #16988

Closed
wants to merge 1 commit into from
Closed

fix(functional-test): update failing coupon tests #16988

wants to merge 1 commit into from

Conversation

sardesam
Copy link
Contributor

Because

  • We are aiming to make stage and prod deployments all green.
  • There is still flakiness.

This pull request

Issue that this pull request solves

Closes FXA-9689

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

fix(functional-test): update failing coupon tests
39ba6bf 
Because:

* We are aiming to make stage and prod deployments all green.
* There is still flakiness.

This commit:

* Updates tests to add a longer timeout to page locators.
* Follow up to #16983.

Closes FXA-9689
@sardesam sardesam requested a review from a team as a code owner May 22, 2024 14:08
@netlify Netlify
Copy link

netlify bot commented May 22, 2024

✅ Deploy Preview for mozilla-fxa ready!

Name Link
🔨 Latest commit 39ba6bf
🔍 Latest deploy log https://app.netlify.com/sites/mozilla-fxa/deploys/664dfc782d708000087196dd
😎 Deploy Preview https://deploy-preview-16988--mozilla-fxa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Trinaa Trinaa closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sardesam @Trinaa