Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build script based on Ant #23

Closed
whimboo opened this issue Mar 5, 2012 · 8 comments
Closed

Create build script based on Ant #23

whimboo opened this issue Mar 5, 2012 · 8 comments
Assignees
Labels
Milestone

Comments

@whimboo
Copy link
Contributor

whimboo commented Mar 5, 2012

Currently you have to zip the files manually but we can automate the XPI creation process with Ant. It's a great process which already helps us a lot for MemChaser (https://github.com/mozilla/memchaser). We would have to wait until issue #22 has been landed.

@xabolcs
Copy link
Collaborator

xabolcs commented Mar 6, 2012

Would You mind to provide releases for AMO's beta channel with this build script?

@whimboo
Copy link
Contributor Author

whimboo commented Mar 8, 2012

Do you have more information about this process on AMO? I haven't used it so far but sounds very interesting.

@xabolcs
Copy link
Collaborator

xabolcs commented Mar 9, 2012

There is a short section in AMO's Maintenance Policy about this process.

I asked that because if you plan beta releases, then the current pre postfix will enough to trigger the beta channel.
But imho an additional information is needed to know: where are the package build from.
It could be a tag (which could be created when doing the AMO release - like I do in my mr2-onair) or could be a commit hash (which could be provided in the building process - like firefox-fuzzyime would do) too.

By the way in this case (Mozilla is the maintainer of NTT), it's not surely needed of that type of channel.
Because You could also give a full review for an uploaded build. And of course the review queues is empty now. :)

@whimboo
Copy link
Contributor Author

whimboo commented Mar 9, 2012

Thanks for the information. I would kindly address anything related to pre-release versions in another issue. For now just lets create the build script to correctly build the XPI. Pre-releases I will upload to the github download section for now.

@whimboo
Copy link
Contributor Author

whimboo commented Mar 9, 2012

Also I'm not an AMO editor and can't do any review of add-ons. Also I wouldn't do it on my own ones.

@xabolcs
Copy link
Collaborator

xabolcs commented Mar 9, 2012

OK, I will file then.

Please note that build script should include the downloadable binary components in the AMO relase.

@whimboo
Copy link
Contributor Author

whimboo commented Mar 9, 2012

The binaries would always have to be included. But hey, why is the zip archive empty?

https://github.com/mozilla/nightlytt/downloads

@whimboo
Copy link
Contributor Author

whimboo commented Mar 9, 2012

Why can't we simply add those files to the repository but offer them as download? @harthur or @tonymec, does one of you know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants