Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update Add-on Compatibility prefs #48

Merged
merged 0 commits into from

3 participants

@brianking

For issue #14. The latest Aurora is 13, but I have added a couple of versions further to cover us for a couple more releases.

.xxb prefs are no longer needed as we don't use beta versioning in Firefox anymore.

@brianking

Hrm, I am wondering why a new issue was created for this when I already linked the pull request to Issue #14?

@whimboo
Owner

It's strange, right. And I haven't figured out how to prevent this yet. So far you can only circumvent this by using the RestAPI when submitting a pull request.

extension/components/nttAddonCompatibilityService.js
@@ -120,6 +152,20 @@ nttAddonCompatibilityService.prototype = {
"extensions.checkCompatibility.2.2b",
"extensions.checkCompatibility.2.4a",
"extensions.checkCompatibility.2.4b",
+ "extensions.checkCompatibility.2.5",
+ "extensions.checkCompatibility.2.5a",
+ "extensions.checkCompatibility.2.6",
+ "extensions.checkCompatibility.2.6a",
+ "extensions.checkCompatibility.2.7",
+ "extensions.checkCompatibility.2.7a",
+ "extensions.checkCompatibility.2.8",
+ "extensions.checkCompatibility.2.8a",
+ "extensions.checkCompatibility.2.9",
+ "extensions.checkCompatibility.2.9a",
+ "extensions.checkCompatibility.2.10",
+ "extensions.checkCompatibility.2.10a",
+ "extensions.checkCompatibility.2.11",
+ "extensions.checkCompatibility.2.11a",
"extensions.checkCompatibility.nightly"];
}
else if (appInfo.name == "Songbird") {
@whimboo Owner
whimboo added a note

Can we also do the same for Songbird? The current nightlies are at 1.12.0a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
extension/components/nttAddonCompatibilityService.js
@@ -90,6 +90,22 @@ nttAddonCompatibilityService.prototype = {
@xabolcs Owner
xabolcs added a note

Would You mind to add "extensions.checkCompatibility.4.0", too? It would fix Bug 650634.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@brianking

This is ready again for review ... 2 commits.

extension/chrome/skin/browser.css
@@ -42,3 +42,7 @@
toolbar[iconsize="small"] #nightly-tester-enter {
list-style-image: url("chrome://nightly/skin/idsmall.png");
}
+
+.popup-notification-icon[popupid="nightly-compatibility-restart"] {
+ list-style-image: url("chrome://nightly/content/brand/logo.png");
+}
@whimboo Owner
whimboo added a note

This should be attached as a separate pull request. Please remove it from that one.

How do I do that?

@whimboo Owner
whimboo added a note

Revert this change in your current branch, create a new one and apply it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@whimboo
Owner

Brian, just came into my mind. Haven't we had some magic for ACR which has been detected the application version automatically and setup the right compatibility pref? That way we wouldn't have to do any of the above prefs addition anymore.

@brianking

We ended up not doing that for ACR because we didn't need to in the end when CBD landed. Yes, it would be ideal here but I suggest we land this, file a separate issue, and do it for the release after next.

@whimboo
Owner

Thanks for the quick response. So yeah, lets hard-code for now and file a new issue. If time permits I'm even happy to fold it into the 3.3 release then.

@xabolcs
Owner

whimboo comented

... which has been detected the application version automatically and setup the right compatibility pref? That way we wouldn't have to do any of the above prefs addition anymore.

That's what I was talking about a month ago. Nobody cares? :(

See my comment in #14:

IMHO if somebody would like to touch nttAddonCompatibilityService.js (read: revamp NTT's force-compatiblity feature) then he/she should consider about Kris Maglione's work in his addon in addition - how to set only the necessary and sufficient subset of extensions.checkCompatibility.* preferences.

@brianking brianking merged commit 997df8e into from
@whimboo
Owner

@xabolcs we simply forgot about that. Can you please file the new issue and c&p that content in there? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Sorry, commit information is not available for this pull request.

Something went wrong with that request. Please try again.