Update Add-on Compatibility prefs #48
Conversation
|
Hrm, I am wondering why a new issue was created for this when I already linked the pull request to Issue #14? |
|
It's strange, right. And I haven't figured out how to prevent this yet. So far you can only circumvent this by using the RestAPI when submitting a pull request. |
| "extensions.checkCompatibility.2.10", | ||
| "extensions.checkCompatibility.2.10a", | ||
| "extensions.checkCompatibility.2.11", | ||
| "extensions.checkCompatibility.2.11a", | ||
| "extensions.checkCompatibility.nightly"]; | ||
| } | ||
| else if (appInfo.name == "Songbird") { |
There was a problem hiding this comment.
Can we also do the same for Songbird? The current nightlies are at 1.12.0a.
|
This is ready again for review ... 2 commits. |
|
|
||
| .popup-notification-icon[popupid="nightly-compatibility-restart"] { | ||
| list-style-image: url("chrome://nightly/content/brand/logo.png"); | ||
| } |
There was a problem hiding this comment.
This should be attached as a separate pull request. Please remove it from that one.
There was a problem hiding this comment.
How do I do that?
There was a problem hiding this comment.
Revert this change in your current branch, create a new one and apply it there.
|
Brian, just came into my mind. Haven't we had some magic for ACR which has been detected the application version automatically and setup the right compatibility pref? That way we wouldn't have to do any of the above prefs addition anymore. |
|
We ended up not doing that for ACR because we didn't need to in the end when CBD landed. Yes, it would be ideal here but I suggest we land this, file a separate issue, and do it for the release after next. |
|
Thanks for the quick response. So yeah, lets hard-code for now and file a new issue. If time permits I'm even happy to fold it into the 3.3 release then. |
|
whimboo comented
That's what I was talking about a month ago. Nobody cares? :( See my comment in #14:
|
|
@xabolcs we simply forgot about that. Can you please file the new issue and c&p that content in there? Thanks. |
For issue #14. The latest Aurora is 13, but I have added a couple of versions further to cover us for a couple more releases.
.xxb prefs are no longer needed as we don't use beta versioning in Firefox anymore.