Bug 1199329 - Auth Delegation should ignore the query string parameters of a callback URI when determining uniqueness

dylanwh · dylanwh · commit 52c93e6088a1 · 2015-08-27T23:45:06.000-04:00
diff --git a/auth.cgi b/auth.cgi
@@ -64,7 +64,7 @@ if ($confirmed || $skip_confirmation) {
                            { token => $token, callback => $callback });
         }
     }
-    my $app_id = sha256_hex($callback_uri, $description);
+    my $app_id = sha256_hex($callback_base, $description);
     my $keys = Bugzilla::User::APIKey->match({
         user_id => $user->id,
         app_id  => $app_id,

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ if ($confirmed \|\| $skip_confirmation) {`
`64`	`64`	`{ token => $token, callback => $callback });`
`65`	`65`	`}`
`66`	`66`	`}`
`67`		`- my $app_id = sha256_hex($callback_uri, $description);`
	`67`	`+ my $app_id = sha256_hex($callback_base, $description);`
`68`	`68`	`my $keys = Bugzilla::User::APIKey->match({`
`69`	`69`	`user_id => $user->id,`
`70`	`70`	`app_id => $app_id,`