Add Hebrew support #3405

amcaplan · 2017-03-22T18:16:07Z

My best crack at this. Kudos to @M-Zuber for the Hebrew help. Still looking for a native speaker to add a second opinion (there were some questions about singular/plural), but it'll also help to see it in Sidekiq Web and look for places these are used where I wasn't expecting.

mperham · 2017-03-22T18:21:10Z

Thank you!

bf4 · 2017-03-23T06:48:12Z

@reuven @shlomi-noach @arikfr @rantav @olahav אם במקרה יש לכם פנאי לבדוק את התרגום... נעריץ את זה מאוד

)סליחה אם קצת בלבלתם את המום עם העברית המקולקת שלי :) )

(לא את כולכם הכרתי. אני מאזין לרברסים לפעמים(

shlomi-noach · 2017-03-23T14:10:15Z

This PR seems to have been merged. I find a few mistakes or unorthodox translations in it and am also missing context.

In the future, may I suggest waiting for at least a day or two to allow me to review, in such case as I'm pinged in person.

Good luck!

amcaplan · 2017-03-23T14:17:37Z

@shlomi-noach https://twitter.com/mperham/status/844608626794815490 for context - we knew this wasn't perfect, just a quick attempt by someone who could get it started. I used some tech Hebrew sites for help, but had to make a few guesses in the hopes that someone like you would correct me where I messed up.

I assume there will be more of an effort to get this right before a non-beta release. In the meantime, seeing where these are used in Sidekiq Web might help deciding on some things like זכר/נקבה and יחיד/רבים.

amcaplan · 2017-03-23T14:35:13Z

Hmmm, seems like I was the one missing context. I assumed people mentioned here were associated with Sidekiq somehow.

@bf4 your commitment to making Sidekiq more available to Hebrew speakers is admirable. I don't think it's reasonable to ping people you don't know personally who have no connection to or interest in the project, assuming they have time and interest in contributing. I have made my own contacts, but they're people I know and can ask favors from, or who have interest in the intersection of Ruby and the Hebrew-speaking/Israeli community.

The open source world is a community of volunteers, very busy volunteers, who give generously of their time for projects they feel connected to and want to see succeed. Let's make sure to respect them and the hard work they do.

amcaplan · 2017-03-23T14:39:18Z

Speaking of people who care about Ruby and Israel: @fogelmania I was a little disappointed at RailsIsrael when I asked who uses Sidekiq and very few hands went up. Maybe with your help on Hebrew support we can increase that number for the next conference? 😉 Or at least a Tweet might help?

mperham · 2017-03-23T18:08:25Z

Improvements to the translations are always welcome and, yes, let's avoid pinging people unless they have a known interest in Sidekiq.

bf4 · 2017-03-24T01:22:48Z

Sorry to anyone who was bothered by my mentions. I carefully thought of who I knew who was active in open source, had worked or works with Ruby, and is a native speaker. Reuven I know personally. Ran and Ori have an amazing tech podcast that I've been following for years, since I first used Outbrain. Shlomi and Arik have both been on the podcast to talk about their oss work, and we use or consider using it. I see now how my pinging came across. My own thinking was that it's a quick thing to look at and comment on, if anyone wanted to. I wasn't thinking about it as interrupting the lives of others and didn't consider whether they had any interest in this particular project. I'd add this to my lessons learned. Thank you all for the gentle rebuke.

shlomi-noach · 2017-03-24T05:30:37Z

I wasn't bothered by the mention and there is no harm on my side. Since such pings come at very low volumes (as opposed to junk mail) I'm capable of just ignoring or unsubscribing.

I work in a distributed team, spread around the world; when I ping someone a PR, I must allow for 24h to pass before proceeding, to make sure everybody had their chance.

What I'd suggest is, if you do ping a stranger, give them some context and give them some time.

Cheers.

rantav

Happy to help, not bothered at all, even though this was merged I still hope my comments are useful.
cheers

rantav · 2017-03-25T20:17:18Z

web/locales/he.yml

+  Namespace: מרחב שם
+  Realtime: זמן אמת
+  History: היסטוריה
+  Busy: עסוקים


עסוקים is plural. Is that right for this context?
If you wanted singular then עסוק is the right word.

I should also note that עסוק is "masculine" noun and some words in hebrew require masculine while others require feminine so it really depends on who is busy?
If it's a "he" in hebrew then indeed עסוק is right, but if it's a "she" in hebrew them it's עסוקה.
Lastly, if it's plural feminine then it's עסוקות.
Tough language, I know...

Anyway, if you told me whether it's plural or singular plus what's the noun busy referring to then I'd tell you what's the correct translation.

The Busy page shows the currently active Sidekiq processes and the jobs they are working on. So "Busy" refers to processes and jobs.

So indeed עסוקים is correct, no need to fix. (processes is masculine plural as in תהליכים עסוקים)

rantav · 2017-03-25T20:18:21Z

web/locales/he.yml

+  Realtime: זמן אמת
+  History: היסטוריה
+  Busy: עסוקים
+  Processed: מעובדים


I'd suggest: עובדו as a more common translation to proccessed in the software sense.

This is the number of jobs processed.

So the correct form is עובדו as I suggested and not מעובדים

rantav · 2017-03-25T20:24:04Z

web/locales/he.yml

+  Queue: תור
+  Class: מחלקה
+  Job: עבודה
+  Arguments: ארגומנטים


משתנים is better

ארגומנטים is really just the english word in hebrew-ish, not a real translation (Read: argumentim, you see it's more or less the same word, not a real translation... )

Actually - scratch that, there's no good translation to arguments so let's just keep this ארגומנטים which is still pretty common amongst developers.

I always thought משתנים are variables; can they mean arguments to a function as well?

In this case, it's arguments to a process, so I'd be even less inclined to think of them as variables.

rantav · 2017-03-25T20:26:41Z

web/locales/he.yml

+  Extras: תוספות
+  Started: הותחלו
+  ShowAll: הצג את הכל
+  CurrentMessagesInQueue: עבודות נוכחיות בתור <span class='title'>%{queue}</span>


הודעות נוכחיות בתור is Current *Messages* In Queue

But if you want to translate Current *Jobs* In Queue then I'd go with מטלות נוכחיות בתור

Yep, messages is legacy terminology. Should be jobs.

OK so let's keep it as is: עבודות נוכחיות בתור <span class='title'>%{queue}</span>

@rantav this confused me a bit. You've referred to jobs as מטלות and עבודות. Are those both correct? Since things should probably be consistent, which is preferred?

I had this dilemma and initially thought מטלות is the better word but then changed my mind and went for עבודות (but forgot to update this comment, sorry...)
Both are correct IMO, מטלות is perhaps the more formal one and עבודות is a bit more casual, so let's go with the casual...

No worries. I got to learn an extra word thanks to your indecision. I count that as a win!

rantav · 2017-03-25T20:30:20Z

web/locales/he.yml

+  RetryCount: מספר נסיונות חוזרים
+  RetryNow: נסה שוב עכשיו
+  Kill: הרוג
+  LastRetry: ניסיון חוזר האחרון


ניסיון חוזר אחרון (removed one letter, better grammar)

rantav · 2017-03-25T20:39:05Z

web/locales/he.yml

+  NoDeadJobsFound: לא נמצאו עבודות מתות
+  Dead: מתים
+  Processes: תהליכים
+  Thread: נים


rantav · 2017-03-25T20:39:22Z

web/locales/he.yml

+  Dead: מתים
+  Processes: תהליכים
+  Thread: נים
+  Threads: נימים


חוטים

While this is a correct translation, I think I would've kept it as Thread and Threads - much easier to understand.

if you're going to allow english then sure threads is fine, but if you want just hebrew then I'd suggest חוטים as plural and חוט in singular.

rantav · 2017-03-25T20:41:17Z

web/locales/he.yml

+  Thread: נים
+  Threads: נימים
+  Jobs: עבודות
+  Paused: נפסקים


Do you want past or present tense?
Or just passive?
If you want passive then נפסקו.
If you want past then also נפסקו
If you want present (simple or progressive) then נפסקים but I don't think that what you want...

You'll see "Paused" when a queue is paused so no one is pulling jobs from that queue. So it would be present tense, as in "this queue is currently paused"

I think: הופסק

I think you want passive and present here and in your example it's also singular (is this going to be singular all the time?)
this queue is currently paused translates to התור הזה הופסק (singular, present, passive)
So actually the right translation for singular present and passive is הופסק

This gets into a question raised previously by @M-Zuber. A lot of these things are essentially menu options, e.g.:

and when you click on something (in this case "Busy") you get:

My instinct is that they make sense to be plural in these contexts, but @M-Zuber thought they'd be expected to be singular. Though in the second image, maybe Started should be singular, since the implication is "Time the [individual] process was started"

OK so anyway for singular it's הופסק and for plural is הופסקו
It you don't know weather it's going to be singular or plural, probably the safer bet is plural, which even though isn't grammatically correct in singular context, looks less weird...

rantav · 2017-03-25T20:42:13Z

web/locales/he.yml

+  Paused: נפסקים
+  Stop: עצור
+  Quiet: שקט
+  StopAll: עצור את כולם


עצור הכל

rantav · 2017-03-25T20:43:16Z

web/locales/he.yml

+  Quiet: שקט
+  StopAll: עצור את כולם
+  QuietAll: השקט את כולם
+  PollingInterval: רווח בין תשאולים


מרווח זמן בין תשאולים

amcaplan · 2017-03-26T08:05:38Z

Thanks @rantav for the improvements! Just seeking a couple of clarifications, and I'll incorporate into a new branch and PR in the near future.

fogelmania · 2017-03-26T14:14:00Z

Would be happy to help. Please send an email of what to do. Raphael

…

On Thu, Mar 23, 2017 at 4:39 PM, Ariel Caplan ***@***.***> wrote: Speaking of people who care about Ruby and Israel: @fogelmania <https://github.com/fogelmania> I was a little disappointed at RailsIsrael when I asked who uses Sidekiq and very few hands went up. Maybe with your help on Hebrew support we can increase that number for the next conference? 😉 Or at least a Tweet might help? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3405 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACbRmM1AcIvZTXaPCC2dxHxwf8Mrwctoks5rooQbgaJpZM4Mln8S> .

-- Raphael Fogel Twitter: @fogelmania <https://twitter.com/#!/fogelmania>

@rantav

With much help from @rantav, thanks! sidekiq#3405

@rantav

With much help from @rantav, thanks! #3405

Ariel Caplan added 2 commits March 19, 2017 17:51

Add Hebrew localization

b322a45

Improve accuracy of Hebrew (Delete, Retry)

9ceef30

mperham merged commit 0215bfe into sidekiq:5-0 Mar 22, 2017

amcaplan deleted the add-hebrew-support branch March 23, 2017 14:36

mperham added this to the 5.0 milestone Mar 24, 2017

rantav reviewed Mar 25, 2017

View reviewed changes

amcaplan pushed a commit to amcaplan/sidekiq that referenced this pull request Apr 4, 2017

Improve Hebrew translations

3e7fca0

With much help from @rantav, thanks! sidekiq#3405

amcaplan mentioned this pull request Apr 4, 2017

Improve Hebrew Support #3422

Merged

mperham pushed a commit that referenced this pull request Apr 4, 2017

Improve Hebrew translations (#3422)

4eb1e35

With much help from @rantav, thanks! #3405

Add Hebrew support #3405

Add Hebrew support #3405

Uh oh!

Conversation

amcaplan commented Mar 22, 2017

Uh oh!

mperham commented Mar 22, 2017

Uh oh!

bf4 commented Mar 23, 2017

Uh oh!

shlomi-noach commented Mar 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amcaplan commented Mar 23, 2017

Uh oh!

amcaplan commented Mar 23, 2017

Uh oh!

amcaplan commented Mar 23, 2017

Uh oh!

mperham commented Mar 23, 2017

Uh oh!

bf4 commented Mar 24, 2017

Uh oh!

shlomi-noach commented Mar 24, 2017

Uh oh!

rantav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shlomi-noach commented Mar 23, 2017 •

edited

Loading