Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better animation documentation #10103

Closed
4 tasks done
majimboo opened this issue Nov 11, 2016 · 7 comments
Closed
4 tasks done

Better animation documentation #10103

majimboo opened this issue Nov 11, 2016 · 7 comments

Comments

@majimboo
Copy link

majimboo commented Nov 11, 2016

I think we should have a better animation documentation. Like what kind of matrices should be entered to create the actions, specially for us who has custom file formats for 3d objects, bones and animation.

The documentation could temporary even just link to the source code that does the transformation of the bones based on the frame matrices provided and the developer could understand for himself.

This things wouldn't be needed though for people who use the exporter from blender and the likes.

I also noticed some documentation templates are in the source but can't be found on the docs site. Any reasons for this?

Great work on Three.js! Cheers

Description of the problem

Missing documentation.

Three.js version
  • Dev
  • r82
Browser
  • All of them
OS
  • All of them
Hardware Requirements (graphics card, VR Device, ...)
@looeee
Copy link
Collaborator

looeee commented Nov 11, 2016

I recently updated the animation documentation, it's on the dev branch but not r82. Have you seen it?

It's quite basic though as yet, I agree it definitely needs more detail.

@majimboo
Copy link
Author

Any idea what kind of bone matrices the animation system accepts: local, model, or world?

@mrdoob
Copy link
Owner

mrdoob commented Nov 13, 2016

/ping @tschw

@majimboo
Copy link
Author

Found out, you need to provide local to hierarchy matrices.

@looeee
Copy link
Collaborator

looeee commented Dec 15, 2016

Stub documentation has been added for all Animation classes. Unfortunately this part of the code is considerably more complex than anything else (except for the renderer and shaders) and I haven't had time to understand it well enough to write documentation... and don't have much inclination to either as I use GSAP for animation.

@tschw, @bhouston, it looks like you guys wrote most of it (along with David Sarno, but I can't find his github handle) - do you think you might be able to write some documentation? I'd be happy to go over formatting/add links so on if the basic property/method/usage descriptions were in place.

As it stands, I think most people will not use this system as it is hard to understand from the code and provided examples.

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 25, 2017

@mrdoob I think we can close this issue. @looeee, @jostschmithals, @donmccurdy and others did a great job in improving the documentation over the last month 👍

@jostschmithals
Copy link
Contributor

@majimboo The new articles are not yet published, but they can already be seen in the dev branch; for example https://rawgit.com/mrdoob/three.js/dev/docs/#Manual/Next_Steps/Animation_System, https://rawgit.com/mrdoob/three.js/dev/docs/#Reference/Animation/AnimationAction and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants