Fix VideoTexture #24769
Closed
Fix VideoTexture #24769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
commented
Oct 10, 2022
|
|
||
| if ( video.readyState >= video.HAVE_CURRENT_DATA ) { | ||
|
|
||
| this.needsUpdate = true; |
There was a problem hiding this comment.
Because update is now called at construction, if there is no RVFC, this line can set needsUpdate to true just when the texture is created (which shouldn't break anything, I think, but unsure). Can fix this if desired.
|
Like mentioned in the other PR, this change introduces too much code complexity. |
|
It's just five more lines, effectively... |
|
@LeviPesin Right... But if I remember correctly, no other texture allows changing the source anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #24758 and #24768
Fixes #24757
Description
Fix VideoTexture by recreating the callback in
VideoTexture.update()if needed.