DRAFT: Potencial fix for VideoTexture

[eXponenta]

Related issue: #24757

Description

Check texture reference in update method safly, null supported.

DRAFT, this is as idea!

[LeviPesin]

You should stop the previous callback loop when creating a new one (by storing the callback ID and calling cancelVideoFrameCallback on it).

[eXponenta]

Yep, this is problem.

We should store and callbackId and source reference, that add already 2 extra field to instance, what is undesirable

[LeviPesin]

Another way to solve would be just to check in update function whether the callback source and the video are still the same, and request callback only if they still are.

[LeviPesin]

The check can be made in the start of update, so if the video changes the old callback would return before setting needsUpdate to true.

update is ticks with render FPS, and you can't requiest video callback from update each call.

But you do currently?

[eXponenta]

Yep, this will siplify code.

[LeviPesin]

Suggested change

	if ( this._callbackSource !== video ) return;

A simpler alternative to 1469756.

[Mugen87]

Sorry, but I think the PR introduces a complexity in VideoTexture which is no acceptable to address #24757. Right now, I think it's best to update the documentation and state that it's not possible to change the video after the creation of a VideoTexture. There is a similar restriction in place for the dimensions, format, and type of a texture.