envmap_vertex: Corrected calculation of world normal #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this related to #7111? |
mrdoob
added a commit
that referenced
this pull request
Sep 28, 2015
envmap_vertex: Corrected calculation of world normal
I doubt it. |
|
I bet it's something similar... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't apply an arbitrary matrix to transform a normal -- we have to use the normal matrix.
The normal matrix for transforms into camera space is available, but the normal matrix for transforms into world space is not.
The solution is to transform the normal to camera space, and then back to world space using (the inverse of) the view matrix, which is available.
This error was only evident for non-uniformly-scaled meshes rendered with
MeshBasicMaterialorMeshLambertMaterialthat also have an environment map.No wonder.