-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CMake package name of C library to msgpackc #1044
Conversation
AppVeyor build is failing with:
That does not seem related to this PR. |
I guess that you need to update zlib on appveyor. https://github.com/msgpack/msgpack-c/blob/c_master/appveyor.yml#L25 The current version is zlib 1.2.13 |
Still 1.2.12 code is remained in appveyor.yml. Please search "1.2.12" and replace them. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## c_master #1044 +/- ##
=========================================
Coverage 55.45% 55.45%
=========================================
Files 8 8
Lines 1044 1044
=========================================
Hits 579 579
Misses 465 465 |
The CI is green. The only job that failed is " CI / linux (5) (pull_request) Failing after 1m ", but that is an error independent from the PR, and will probably go away if you restart the job (see actions/runner-images#675). |
Thanks, I restarted CI and finally got all green. I will merge it. |
Change the CMake package name to msgpackc, as requested in #1043 (comment) . After this change, to find the C library in the system, it is necessary to call:
instead of the previously used:
Fix #1043 .