Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CMake package name of C library to msgpackc #1044

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

traversaro
Copy link

@traversaro traversaro commented Jan 5, 2023

Change the CMake package name to msgpackc, as requested in #1043 (comment) . After this change, to find the C library in the system, it is necessary to call:

find_package(msgpackc REQUIRED)

instead of the previously used:

find_package(msgpack REQUIRED)

Fix #1043 .

@traversaro traversaro changed the title Change CMake package name to msgpackc Change CMake package name of C library to msgpackc Jan 5, 2023
@traversaro
Copy link
Author

AppVeyor build is failing with:

-- Build files have been written to: C:/projects/msgpack-c/googletest-release-1.7.0/build
cmake --build . --config Release
Microsoft (R) Build Engine version 4.8.3761.0
[Microsoft .NET Framework, version 4.0.30319.42000]
Copyright (C) Microsoft Corporation. All rights reserved.
  Checking Build System
  Building Custom Rule C:/projects/msgpack-c/googletest-release-1.7.0/CMakeLists.txt
  gtest-all.cc
     Creating library C:/projects/msgpack-c/googletest-release-1.7.0/build/Release/gtest.lib and object C:/projects/msgpack-c/googletest-release-1.7.0/build/Release/gtest.exp
  gtest.vcxproj -> C:\projects\msgpack-c\googletest-release-1.7.0\build\Release\gtest.dll
  Building Custom Rule C:/projects/msgpack-c/googletest-release-1.7.0/CMakeLists.txt
  gtest_main.cc
     Creating library C:/projects/msgpack-c/googletest-release-1.7.0/build/Release/gtest_main.lib and object C:/projects/msgpack-c/googletest-release-1.7.0/build/Release/gtest_main.exp
  gtest_main.vcxproj -> C:\projects\msgpack-c\googletest-release-1.7.0\build\Release\gtest_main.dll
  Building Custom Rule C:/projects/msgpack-c/googletest-release-1.7.0/CMakeLists.txt
cd ..
cd ..
appveyor DownloadFile http://zlib.net/zlib-1.2.12.tar.gz -FileName zlib-1.2.12.tar.gz
Error downloading remote file: One or more errors occurred.
Inner Exception: Remote server returned 404: Not Found

That does not seem related to this PR.

@redboltz
Copy link
Contributor

redboltz commented Jan 7, 2023

I guess that you need to update zlib on appveyor.

https://github.com/msgpack/msgpack-c/blob/c_master/appveyor.yml#L25
And other lines.

The current version is zlib 1.2.13

@redboltz
Copy link
Contributor

redboltz commented Jan 7, 2023

Still 1.2.12 code is remained in appveyor.yml. Please search "1.2.12" and replace them.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #1044 (5ae6077) into c_master (c3df1bb) will not change coverage.
The diff coverage is n/a.

❗ Current head 5ae6077 differs from pull request most recent head 52fa748. Consider uploading reports for the commit 52fa748 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           c_master    #1044   +/-   ##
=========================================
  Coverage     55.45%   55.45%           
=========================================
  Files             8        8           
  Lines          1044     1044           
=========================================
  Hits            579      579           
  Misses          465      465           

@traversaro traversaro closed this Jan 10, 2023
@traversaro traversaro reopened this Jan 10, 2023
@traversaro traversaro closed this Jan 10, 2023
@traversaro traversaro reopened this Jan 10, 2023
@traversaro
Copy link
Author

The CI is green. The only job that failed is " CI / linux (5) (pull_request) Failing after 1m ", but that is an error independent from the PR, and will probably go away if you restart the job (see actions/runner-images#675).

@redboltz
Copy link
Contributor

Thanks, I restarted CI and finally got all green. I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants