-
Notifications
You must be signed in to change notification settings - Fork 171
releng for v1.3.0 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
It is alike to `decodeAsync()`, but only accepts an array of items as `stream`, and emits the decoded item one-by-one. | ||
|
||
It throws errors when the input is not an array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to add example scripts (and add it to test/readme.test.ts) in a future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I think we need code example for it
@sergeyzenchenko Do you make extra pull-requests for 1.3.0? Otherwise, I'll release it after #46 and #44 are merged. |
ready for release @gfx |
Thanks 😄 Will release v1.3.0 after Ci passes. |
btw @gfx do you know if https://github.com/msgpack/msgpack-objectivec is abandoned ? |
I have no idea about msgpack-objectivec. If you interested in it, ask @frsyuki (https://twitter.com/frsyuki ) about it. In fact, I have started to maintain the repo recently by asking him for the repo's ownership. |
There seems a objective-c implementation that is still active: https://github.com/gabriel/MPMessagePack As https://msgpack.org/ shows. |
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 15 15
Lines 840 840
Branches 175 175
=======================================
Hits 785 785
Misses 29 29
Partials 26 26 Continue to review full report at Codecov.
|
yeah, we are using modified version of https://github.com/gabriel/MPMessagePack |
👍 v1.3.0 is available now https://www.npmjs.com/package/@msgpack/msgpack |
I'm thinking about whether or not I should make pull-requests for each release 🤔