Skip to content

Conversation

gfx
Copy link
Member

@gfx gfx commented May 30, 2019

I'm thinking about whether or not I should make pull-requests for each release 🤔


It is alike to `decodeAsync()`, but only accepts an array of items as `stream`, and emits the decoded item one-by-one.

It throws errors when the input is not an array.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add example scripts (and add it to test/readme.test.ts) in a future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think we need code example for it

@gfx
Copy link
Member Author

gfx commented May 30, 2019

@sergeyzenchenko Do you make extra pull-requests for 1.3.0? Otherwise, I'll release it after #46 and #44 are merged.

@gfx gfx requested a review from sergeyzenchenko May 30, 2019 13:22
@sergeyzenchenko
Copy link
Collaborator

ready for release @gfx

@gfx
Copy link
Member Author

gfx commented May 30, 2019

Thanks 😄

Will release v1.3.0 after Ci passes.

@sergeyzenchenko
Copy link
Collaborator

btw @gfx do you know if https://github.com/msgpack/msgpack-objectivec is abandoned ?
No updates for 6 years :D

@gfx
Copy link
Member Author

gfx commented May 30, 2019

I have no idea about msgpack-objectivec.

If you interested in it, ask @frsyuki (https://twitter.com/frsyuki ) about it. In fact, I have started to maintain the repo recently by asking him for the repo's ownership.

@gfx
Copy link
Member Author

gfx commented May 30, 2019

There seems a objective-c implementation that is still active: https://github.com/gabriel/MPMessagePack

As https://msgpack.org/ shows.

@codecov-io
Copy link

codecov-io commented May 30, 2019

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   93.45%   93.45%           
=======================================
  Files          15       15           
  Lines         840      840           
  Branches      175      175           
=======================================
  Hits          785      785           
  Misses         29       29           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d59417...20ed989. Read the comment docs.

@gfx gfx merged commit 0a0d052 into master May 30, 2019
@gfx gfx deleted the releng-1.3.0 branch May 30, 2019 14:22
@sergeyzenchenko
Copy link
Collaborator

yeah, we are using modified version of https://github.com/gabriel/MPMessagePack
Just was curios what's going on with official lib :)

@gfx
Copy link
Member Author

gfx commented May 30, 2019

👍

v1.3.0 is available now https://www.npmjs.com/package/@msgpack/msgpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants