Skip to content

[system] Add missing TypeScript types for display, flexbox positions, shadows #15781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2019
Merged

[system] Add missing TypeScript types for display, flexbox positions, shadows #15781

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0466dbd
Add missing style functions for display, flexbox, positions and shadows
May 21, 2019
d6dc32f
Add missing semicolons
May 21, 2019
8aa5a7b
Fix typescript test
May 22, 2019
1b33515
Restore TS
May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions packages/material-ui-system/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,35 @@ export function css<Props>(
styleFunction: StyleFunction<Props>,
): StyleFunction<Props & { css: Omit<Props, 'theme'> }>;

// default display.js TODO

// * flexbox.js TODO
export const display: SimpleStyleFunction<'display' | 'displayPrint'>;
export type DisplayProps = PropsFor<typeof display>;

export const flexbox: SimpleStyleFunction<
| 'flexboxDirection'
| 'flexWrap'
| 'justifyContent'
| 'alignItems'
| 'alignContent'
| 'order'
| 'flexGrow'
| 'flexShrink'
| 'alignSelf'
>;
export type FlexboxProps = PropsFor<typeof flexbox>;

// palette.js
export const color: SimpleStyleFunction<'color'>;
export const bgcolor: SimpleStyleFunction<'bgcolor'>;
export const palette: SimpleStyleFunction<'bgcolor' | 'color'>;
export type PaletteProps = PropsFor<typeof palette>;

// * positions.js TODO
export const positions: SimpleStyleFunction<
'zIndex' | 'position' | 'top' | 'right' | 'bottom' | 'left'
>;
export type PositionsProps = PropsFor<typeof positions>;

// default shadows.js TODO
export const shadows: SimpleStyleFunction<'boxShadow'>;
export type ShadowsProps = PropsFor<typeof shadows>;

// * sizing.js TODO
export const width: SimpleStyleFunction<'width'>;
Expand Down