[material-ui][TextField][FormLabel][InputLabel][FormControl] Use exact children type to allow React children type augmentation #38872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38872--material-ui.netlify.app/ Bundle size report |
Contributor
Author
|
Hey, just wanted to check in on this. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
ZeeshanTamboli
added
typescript
scope: autocomplete
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
scope: text field
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
This looks good. Let's remove the test though. We can do this change to allow React type augmentation.
packages/mui-material/test/typescript/reactAugmentation/children.spec.tsx
Outdated
Show resolved
Hide resolved
ZeeshanTamboli
changed the title
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
ZeeshanTamboli
approved these changes
Jan 4, 2024
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
@nicegamer7 I have applied the expected changes by removing the test. Looks good now, thanks!
ZeeshanTamboli
changed the title
Contributor
Author
|
Thanks for taking care of this! |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
…t children type to allow React children type augmentation (mui#38872) Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some inconsistencies with the typings of some of the MUI Material components, which led to type errors when the React children type was augmented. There may be more of these inconsistencies that I missed.
react-i18next is an example package that augments React's types, allowing objects to be passed as children. Without these changes, several react-i18next users were experiencing type-errors (i18next/react-i18next#1543 (comment)) related to the Autocomplete component.