[code-infra] Break package dependency cycle between @mui/material and @mui/icons-material #40400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… @mui/icons-material
michaldudak
added
the
scope: code-infra
Netlify deploy previewhttps://deploy-preview-40400--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Jan 2, 2024
Member
There was a problem hiding this comment.
Ok, the dependency is only there because of testing. If you look at it from a different angle, it's sort of an integration test. Integrating @mui/material with @mio/icons-material. One could argue the test belongs in the top-level. But in practice this is not a integration test. The solution seems good enough for this case 👍
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
… @mui/icons-material (mui#40400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #40398. I missed a cycle between @mui/material and @mui/icons-material.