Performance tweaks for CEF AJAX

Author: Dutchman101

Client/cefweb/CAjaxResourceHandler.cpp

@@ -27,13 +27,13 @@ CAjaxResourceHandler::~CAjaxResourceHandler()
     m_callback = nullptr;
 }
 
-void CAjaxResourceHandler::SetResponse(const std::string& data)
+void CAjaxResourceHandler::SetResponse(std::string data)
 {
     // Prevent response corruption: ignore subsequent calls after data is set
     if (m_bHasData) [[unlikely]]
         return;
 
-    m_strResponse = data;
+    m_strResponse = std::move(data);
     m_bHasData = true;
 
     if (!m_callback)
@@ -72,14 +72,17 @@ void CAjaxResourceHandler::GetResponseHeaders(CefRefPtr<CefResponse> response, i
 
 bool CAjaxResourceHandler::ProcessRequest([[maybe_unused]] CefRefPtr<CefRequest> request, CefRefPtr<CefCallback> callback)
 {
+    if (!callback)
+        return false;
+
     // Store callback so SetResponse can resume once data is ready
     m_callback = callback;
 
     // Do not call Continue() yet; SetResponse triggers it after data is prepared
     return true;
 }
 
-bool CAjaxResourceHandler::ReadResponse(void* data_out, int bytes_to_read, int& bytes_read, CefRefPtr<CefCallback> callback)
+bool CAjaxResourceHandler::ReadResponse(void* data_out, int bytes_to_read, int& bytes_read, [[maybe_unused]] CefRefPtr<CefCallback> callback)
 {
     // Validate input parameters first
     if (!data_out || bytes_to_read <= 0) [[unlikely]]

Client/cefweb/CAjaxResourceHandler.h

@@ -13,6 +13,7 @@
 #include <core/CAjaxResourceHandlerInterface.h>
 #include <cef3/cef/include/cef_resource_handler.h>
 #include <SString.h>
+#include <string>
 
 class CWebView;
 
@@ -24,7 +25,7 @@ class CAjaxResourceHandler : public CefResourceHandler, public CAjaxResourceHand
 
     std::vector<std::string>& GetGetData() override { return m_vecGetData; }
     std::vector<std::string>& GetPostData() override { return m_vecPostData; }
-    void SetResponse(const std::string& data) override;
+    void SetResponse(std::string data) override;
 
     // CefResourceHandler
     virtual void Cancel() override;

Client/cefweb/CWebApp.cpp

@@ -201,6 +201,10 @@ CefRefPtr<CefResourceHandler> CWebApp::Create(CefRefPtr<CefBrowser> browser, Cef
                     vecTmp.reserve(8);  // Reserve space for common query parameter count
                     strGet.Split("&", vecTmp);
 
+                    const size_t paramCount = vecTmp.size();
+                    if (paramCount > 0)
+                        vecGet.reserve(vecGet.size() + paramCount * 2);
+
                     SString key;
                     SString value;
                     for (auto&& param : vecTmp)
@@ -239,6 +243,10 @@ CefRefPtr<CefResourceHandler> CWebApp::Create(CefRefPtr<CefBrowser> browser, Cef
                         vecTmp.reserve(8);
                         postParam.Split("&", vecTmp);
 
+                        const size_t postParamCount = vecTmp.size();
+                        if (postParamCount > 0)
+                            vecPost.reserve(vecPost.size() + postParamCount * 2);
+
                         for (auto&& param : vecTmp)
                         {
                             param.Split("=", &key, &value);

Client/mods/deathmatch/logic/CClientWebBrowser.cpp

@@ -328,9 +328,9 @@ void CClientWebBrowser::Events_OnAjaxRequest(CAjaxResourceHandlerInterface* pHan
         return;
     }
 
-    auto        callback = callbackMapEntry->second;
+    auto&       callback = callbackMapEntry->second;
     std::string result = callback(pHandler->GetGetData(), pHandler->GetPostData());
-    pHandler->SetResponse(result);
+    pHandler->SetResponse(std::move(result));
 }
 
 void CClientWebBrowser::Events_OnConsoleMessage(const std::string& message, const std::string& source, int line, std::int16_t level)

Client/sdk/core/CAjaxResourceHandlerInterface.h

@@ -18,5 +18,5 @@ class CAjaxResourceHandlerInterface
 public:
     virtual std::vector<std::string>& GetGetData() = 0;
     virtual std::vector<std::string>& GetPostData() = 0;
-    virtual void                      SetResponse(const std::string& data) = 0;
+    virtual void                      SetResponse(std::string data) = 0;
 };

Client/sdk/core/CWebViewInterface.h

@@ -8,6 +8,11 @@
  *
  *****************************************************************************/
 #pragma once
+
+#include <functional>
+#include <string>
+#include <vector>
+
 #include "CWebCoreInterface.h"
 
 class CWebBrowserEventsInterface;