Add "coronareflections" property to setWorldSpecialPropertyEnabled

(true by default)

Author: lopezloo

Client/game_sa/CGameSA.cpp

@@ -603,6 +603,9 @@ bool CGameSA::IsCheatEnabled(const char* szCheatName)
     if (!strcmp(szCheatName, PROP_UNDERWORLD_WARP))
         return IsUnderWorldWarpEnabled();
 
+    if (!strcmp(szCheatName, PROP_CORONA_REFLECTIONS))
+        return IsCoronaReflectionsEnabled();
+
     std::map<std::string, SCheatSA*>::iterator it = m_Cheats.find(szCheatName);
     if (it == m_Cheats.end())
         return false;
@@ -635,6 +638,12 @@ bool CGameSA::SetCheatEnabled(const char* szCheatName, bool bEnable)
         return true;
     }
 
+    if (!strcmp(szCheatName, PROP_CORONA_REFLECTIONS))
+    {
+        SetCoronaReflectionsEnabled(bEnable);
+        return true;
+    }
+
     std::map<std::string, SCheatSA*>::iterator it = m_Cheats.find(szCheatName);
     if (it == m_Cheats.end())
         return false;
@@ -651,6 +660,7 @@ void CGameSA::ResetCheats()
     SetMoonEasterEggEnabled(false);
     SetExtraAirResistanceEnabled(true);
     SetUnderWorldWarpEnabled(true);
+    SetCoronaReflectionsEnabled(true);
 
     std::map<std::string, SCheatSA*>::iterator it;
     for (it = m_Cheats.begin(); it != m_Cheats.end(); it++)
@@ -707,6 +717,25 @@ bool CGameSA::IsUnderWorldWarpEnabled()
     return !m_bUnderworldWarp;
 }
 
+void CGameSA::SetCoronaReflectionsEnabled(bool bEnabled)
+{
+    // Restore or disable calls to CCoronas::RenderReflections
+    if(bEnabled) {
+        MemCpy((void*)0x53DFD8, "\xE8\x53\xD6\x1B\x00", 5);
+        MemCpy((void*)0x53DCAC, "\xE8\x7F\xD9\x1B\x00", 5);
+    }
+    else {
+        MemSet((void*)0x53DFD8, 0x90, 5);
+        MemSet((void*)0x53DCAC, 0x90, 5);
+    }
+    m_bCoronaReflections = bEnabled;
+}
+
+bool CGameSA::IsCoronaReflectionsEnabled()
+{
+    return m_bCoronaReflections;
+}
+
 bool CGameSA::GetJetpackWeaponEnabled(eWeaponType weaponType)
 {
     if (weaponType >= WEAPONTYPE_BRASSKNUCKLE && weaponType < WEAPONTYPE_LAST_WEAPONTYPE)

Client/game_sa/CGameSA.h

@@ -85,6 +85,7 @@ extern unsigned int OBJECTDYNAMICINFO_MAX;  // default: 160
 #define PROP_SNIPER_MOON            "snipermoon"
 #define PROP_EXTRA_AIR_RESISTANCE   "extraairresistance"
 #define PROP_UNDERWORLD_WARP        "underworldwarp"
+#define PROP_CORONA_REFLECTIONS     "coronareflections"
 
 struct SCheatSA
 {
@@ -409,6 +410,9 @@ class CGameSA : public CGame
     bool IsUnderWorldWarpEnabled();
     void SetUnderWorldWarpEnabled(bool bEnable);
 
+    bool IsCoronaReflectionsEnabled();
+    void SetCoronaReflectionsEnabled(bool bEnabled);
+
     bool VerifySADataFileNames();
     bool PerformChecks();
     int& GetCheckStatus() { return m_iCheckStatus; }
@@ -505,6 +509,7 @@ class CGameSA : public CGame
     bool         m_bASyncLoadingSuspended;
     int          m_iCheckStatus;
     bool         m_bUnderworldWarp;
+    bool         m_bCoronaReflections;
 
     static unsigned int&  ClumpOffset;
     static unsigned long* VAR_SystemTime;

Client/multiplayer_sa/CMultiplayerSA.cpp

@@ -1523,7 +1523,7 @@ void CMultiplayerSA::InitHooks()
 
     // Fix corona rain reflections aren't rendering (#2345)
     // By using zBufferFar instead of zBufferNear for corona position
-    MemSet((void*)0x6FB9A0, 0x1C, 1);
+    MemPut<BYTE>(0x6FB9A0, 0x1C);
 
     InitHooks_CrashFixHacks();