Revert "Merge remote-tracking branch 'upstream/master' into shadow"

This reverts commit fbad125, reversing
changes made to 60e29ed.

Author: Proxy-99

Client/core/CCommands.cpp

@@ -125,7 +125,6 @@ bool CCommands::Execute(const char* szCommand, const char* szParametersIn, bool
 
     // Grab the command
     tagCOMMANDENTRY* pEntry = Get(szCommand);
-    bool             wasHandled = false;
     if (pEntry)
     {
         // If its a core command, or if its enabled
@@ -134,16 +133,14 @@ bool CCommands::Execute(const char* szCommand, const char* szParametersIn, bool
             // Execute it
             if (!bIsScriptedBind || pEntry->bAllowScriptedBind)
                 ExecuteHandler(pEntry->pfnCmdFunc, szParameters);
-
-            wasHandled = true;
+            return true;
         }
     }
 
     // Recompose the original command text
     std::string val = std::string(szCommand) + " " + std::string(szParameters ? szParameters : "");
 
     // Is it a cvar? (syntax: cvar[ = value])
-    if (!wasHandled)
     {
         // Check to see if '=' exists
         unsigned int nOpIndex = val.find('=');
@@ -191,7 +188,7 @@ bool CCommands::Execute(const char* szCommand, const char* szParametersIn, bool
 
     // HACK: if its a 'nick' command, save it here
     bool bIsNickCommand = !stricmp(szCommand, "nick");
-    if (!wasHandled && bIsNickCommand && szParameters && !bIsScriptedBind)
+    if (bIsNickCommand && szParameters && !bIsScriptedBind)
     {
         if (CCore::GetSingleton().IsValidNick(szParameters))
         {
@@ -211,14 +208,10 @@ bool CCommands::Execute(const char* szCommand, const char* szParametersIn, bool
     // Try to execute the handler
     if (m_pfnExecuteHandler)
     {
-        bool bAllowScriptedBind = (!pEntry || pEntry->bAllowScriptedBind);
-        if (m_pfnExecuteHandler(szCommand, szParameters, bHandleRemotely, wasHandled, bIsScriptedBind, bAllowScriptedBind))
+        if (m_pfnExecuteHandler(szCommand, szParameters, bHandleRemotely, (pEntry != NULL), bIsScriptedBind))
             return true;
     }
 
-    if (wasHandled)
-        return true;
-
     // Unknown command
     val = _("Unknown command or cvar: ") + szCommand;
     if (!bIsScriptedBind && !bIsNickCommand && pEntry == nullptr)

Client/core/CKeyBinds.cpp

@@ -841,8 +841,7 @@ CCommandBind* CKeyBinds::FindCommandMatch(const char* szKey, const char* szComma
     NullEmptyStrings(szKey, szArguments, szResource, szOriginalScriptKey);
 
     std::string arguments = szArguments ? szArguments : "";
-    if (!arguments.empty())
-        szArguments = SharedUtil::Trim(arguments.data());
+    szArguments = SharedUtil::Trim(arguments.data());
 
     for (KeyBindPtr& bind : m_binds)
     {

Client/game_sa/CCameraSA.cpp

@@ -446,15 +446,15 @@ float CCameraSA::GetShakeForce()
 
 void CCameraSA::ShakeCamera(float radius, float x, float y, float z) noexcept
 {
-    static CCameraSAInterface* cameraInterface = GetInterface();
-    if (radius <= 0.0f)
-        return ResetShakeCamera();
-
-    using ShakeCamera_t = void(__thiscall*)(CCameraSAInterface*, float radius, float x, float y, float z);
-    ((ShakeCamera_t)FUNC_ShakeCam)(cameraInterface, radius, x, y, z);
-}
-
-void CCameraSA::ResetShakeCamera() noexcept
-{
-    GetInterface()->m_fCamShakeForce = 0.0f;
+    DWORD               dwFunc = FUNC_ShakeCam;
+    CCameraSAInterface* cameraInterface = GetInterface();
+    _asm
+    {
+        mov  ecx, cameraInterface
+        push z
+        push y
+        push x
+        push radius
+        call dwFunc
+    }
 }

Client/game_sa/CCameraSA.h

@@ -429,5 +429,4 @@ class CCameraSA : public CCamera
     float     GetShakeForce();
 
     void ShakeCamera(float radius, float x, float y, float z) noexcept override;
-    void ResetShakeCamera() noexcept override;
 };

Client/game_sa/CCarEnterExitSA.cpp

@@ -78,19 +78,6 @@ bool CCarEnterExitSA::GetNearestCarPassengerDoor(CPed* pPed, CVehicle* pVehicle,
     return bReturn;
 }
 
-void CCarEnterExitSA::GetPositionToOpenCarDoor(CVector& position, CVehicle* vehicle, std::uint32_t door) const noexcept
-{
-    CVehicleSA* vehicleSA = dynamic_cast<CVehicleSA*>(vehicle);
-
-    if (!vehicleSA)
-        return;
-
-    CVehicleSAInterface* vehicleInterface = vehicleSA->GetVehicleInterface();
-
-    auto CCarEnterExit_GetPositionToOpenCarDoor = (void(__cdecl*)(CVector&, CVehicleSAInterface*, int))FUNC_GetPositionToOpenCarDoor;
-    CCarEnterExit_GetPositionToOpenCarDoor(position, vehicleInterface, door);
-}
-
 int CCarEnterExitSA::ComputeTargetDoorToExit(CPed* pPed, CVehicle* pVehicle)
 {
     DWORD dwFunc = FUNC_ComputeTargetDoorToExit;

Client/game_sa/CCarEnterExitSA.h

@@ -17,14 +17,12 @@
 #define FUNC_GetNearestCarPassengerDoor         0x650BB0
 #define FUNC_ComputeTargetDoorToExit            0x64F110
 #define FUNC_IsRoomForPedToLeaveCar             0x6504C0
-#define FUNC_GetPositionToOpenCarDoor           0x64E740
 
 class CCarEnterExitSA : public CCarEnterExit
 {
 public:
     bool GetNearestCarDoor(CPed* pPed, CVehicle* pVehicle, CVector* pVector, int* pDoor);
     bool GetNearestCarPassengerDoor(CPed* pPed, CVehicle* pVehicle, CVector* pVector, int* pDoor, bool bUnknown, bool bUnknown2, bool bCheckIfRoomToGetIn);
-    void GetPositionToOpenCarDoor(CVector& position, CVehicle* vehicle, std::uint32_t door) const noexcept;
     int  ComputeTargetDoorToExit(CPed* pPed, CVehicle* pVehicle);
     bool IsRoomForPedToLeaveCar(CVehicle* pVehicle, int iDoor, CVector* pUnknown = 0);
 };

Client/game_sa/CClockSA.cpp

@@ -30,19 +30,3 @@ void CClockSA::Get(BYTE* bHour, BYTE* bMinute)
     *bMinute = *(BYTE*)VAR_TimeMinutes;
     *bHour = *(BYTE*)VAR_TimeHours;
 }
-
-bool CClockSA::SetTimeFrozen(bool value) noexcept
-{
-    if (value)
-        MemSet((void*)0x53BFBD, 0x90, 5);
-    else
-        MemCpy((void*)0x53BFBD, "\xE8\x4E\x0F\xFF\xFF", 5);
-
-    m_bTimeCycleFrozen = value;
-    return true;
-}
-
-bool CClockSA::ResetTimeFrozen() noexcept
-{
-    return SetTimeFrozen(false);
-}

Client/game_sa/CClockSA.h

@@ -22,11 +22,4 @@ class CClockSA : public CClock
 public:
     void Set(BYTE bHour, BYTE bMinute);
     void Get(BYTE* bHour, BYTE* bMinute);
-
-    bool SetTimeFrozen(bool value) noexcept;
-    bool IsTimeFrozen() const noexcept { return m_bTimeCycleFrozen; };
-    bool ResetTimeFrozen() noexcept;
-
-private:
-    bool m_bTimeCycleFrozen;
 };

Client/game_sa/CGameSA.cpp

@@ -1005,14 +1005,18 @@ void CGameSA::GetShaderReplacementStats(SShaderReplacementStats& outStats)
     m_pRenderWare->GetShaderReplacementStats(outStats);
 }
 
-void CGameSA::RemoveAllBuildings()
+void CGameSA::RemoveAllBuildings(bool clearBuildingRemoval)
 {
     m_pIplStore->SetDynamicIplStreamingEnabled(false);
 
     m_pPools->GetDummyPool().RemoveAllBuildingLods();
     m_pPools->GetBuildingsPool().RemoveAllBuildings();
 
     auto pBuildingRemoval = static_cast<CBuildingRemovalSA*>(m_pBuildingRemoval);
+    if (clearBuildingRemoval)
+    {
+        pBuildingRemoval->ClearRemovedBuildingLists();
+    }
     pBuildingRemoval->DropCaches();
 
     m_isBuildingsRemoved = true;
@@ -1032,7 +1036,7 @@ bool CGameSA::SetBuildingPoolSize(size_t size)
     const bool shouldRemoveBuilding = !m_isBuildingsRemoved;
     if (shouldRemoveBuilding)
     {
-        RemoveAllBuildings();
+        RemoveAllBuildings(false);
     }
     else
     {

Client/game_sa/CGameSA.h

@@ -303,7 +303,7 @@ class CGameSA : public CGame
     PostWeaponFireHandler*  m_pPostWeaponFireHandler;
     TaskSimpleBeHitHandler* m_pTaskSimpleBeHitHandler;
 
-    void RemoveAllBuildings();
+    void RemoveAllBuildings(bool clearBuildingRemoval = true);
     void RestoreGameBuildings();
 
     bool SetBuildingPoolSize(size_t size);