Compile errors and warnings fixed for GCC 4.6

Author: ccw808

MTA10_Server/mods/deathmatch/logic/CRPCFunctions.cpp

@@ -334,7 +334,7 @@ void CRPCFunctions::RequestStealthKill ( NetBitStreamInterface & bitStream )
                     {
                         CLuaArguments Arguments;
                         Arguments.PushElement ( pTarget );
-                        if ( m_pSourcePlayer->CallEvent ( "onPlayerStealthKill", Arguments, false ) ) 
+                        if ( m_pSourcePlayer->CallEvent ( "onPlayerStealthKill", Arguments ) ) 
                         {
                             // Start the stealth kill
                             CStaticFunctionDefinitions::KillPed ( pTarget, m_pSourcePlayer, 4 /*WEAPONTYPE_KNIFE*/, 9/*BODYPART_HEAD*/, true );

MTA10_Server/mods/deathmatch/logic/CResource.cpp

@@ -2567,9 +2567,6 @@ void Unescape ( std::string& str )
 
 ResponseCode CResource::HandleRequestCall ( HttpRequest * ipoHttpRequest, HttpResponse * ipoHttpResponse, CAccount* account )
 {
-    static int bAlreadyCalling = false; // a mini-mutex flag, seems to work :)
-    // This code runs multithreaded, we need to make sure multiple server requests don't overlap each other... (slows the server down quite a bit)
-
     // Check for http general and if we have access to this resource
     // if we're trying to return a http file. Otherwize it's the MTA
     // client trying to download files.
@@ -2602,7 +2599,6 @@ ResponseCode CResource::HandleRequestCall ( HttpRequest * ipoHttpRequest, HttpRe
     // If denied with both 'new way' and 'old way' then stop here
     if ( !bResourceBlahHttp && ( !bResourceBlah || !bGeneralHttp ) )
     {
-        bAlreadyCalling = false;
         return g_pGame->GetHTTPD()->RequestLogin ( ipoHttpResponse );
     }
 
@@ -2620,7 +2616,6 @@ ResponseCode CResource::HandleRequestCall ( HttpRequest * ipoHttpRequest, HttpRe
     {
         const char* szError = "error: invalid function name";
         ipoHttpResponse->SetBody ( szError, strlen(szError) );
-        bAlreadyCalling = false;
         return HTTPRESPONSECODE_200_OK;
     }
 
@@ -2842,26 +2837,22 @@ ResponseCode CResource::HandleRequestCall ( HttpRequest * ipoHttpRequest, HttpRe
                     g_pGame->GetScriptDebugging()->SaveLuaDebugInfo( SLuaDebugInfo() );
 
                     ipoHttpResponse->SetBody ( strJSON.c_str (), strJSON.length () );
-                    bAlreadyCalling = false;
                     return HTTPRESPONSECODE_200_OK;
                 }
                 else
                 {
-                    bAlreadyCalling = false;
                     return g_pGame->GetHTTPD()->RequestLogin ( ipoHttpResponse );
                 }
             }
             else
             {
-                bAlreadyCalling = false;
                 return g_pGame->GetHTTPD()->RequestLogin ( ipoHttpResponse );
             }
         }
     }
 
     const char* szError = "error: not found";
     ipoHttpResponse->SetBody ( szError, strlen(szError) );
-    bAlreadyCalling = false;
     return HTTPRESPONSECODE_200_OK;
 }
 

MTA10_Server/mods/deathmatch/logic/CStaticFunctionDefinitions.cpp

@@ -1741,7 +1741,7 @@ bool CStaticFunctionDefinitions::SetElementModel ( CElement* pElement, unsigned
             Arguments.PushNumber ( pPed->GetModel() ); // Get the old model
             pPed->SetModel ( usModel ); // Set the new model
             Arguments.PushNumber ( usModel ); // Get the new model
-            pPed->CallEvent ( "onElementModelChange", Arguments, false );
+            pPed->CallEvent ( "onElementModelChange", Arguments );
             break;
         }
         case CElement::VEHICLE:
@@ -1753,7 +1753,7 @@ bool CStaticFunctionDefinitions::SetElementModel ( CElement* pElement, unsigned
             Arguments.PushNumber ( pVehicle->GetModel () ); // Get the old model
             pVehicle->SetModel ( usModel ); // Set the new model
             Arguments.PushNumber ( usModel ); // Get the new model
-            pVehicle->CallEvent ( "onElementModelChange", Arguments, false );
+            pVehicle->CallEvent ( "onElementModelChange", Arguments );
 
             // Check for any passengers above the max seat list
             unsigned char ucMaxPassengers = pVehicle->GetMaxPassengers ();
@@ -1782,7 +1782,7 @@ bool CStaticFunctionDefinitions::SetElementModel ( CElement* pElement, unsigned
             Arguments.PushNumber ( pObject->GetModel () ); // Get the old model
             pObject->SetModel ( usModel ); // Set the new model
             Arguments.PushNumber ( usModel ); // Get the new model
-            pObject->CallEvent ( "onElementModelChange", Arguments, false );
+            pObject->CallEvent ( "onElementModelChange", Arguments );
             break;
         }
         default: return false;

Shared/sdk/CFastList.h

@@ -50,9 +50,11 @@ class CFastList
         , uiNextFrontIndex ( UINT_MAX / 2 - 1 )
         , uiNextBackIndex ( UINT_MAX / 2 )
     {
-        // T must be a pointer
-        void* ptr = (T)NULL;
-        ptr = NULL;
+        #ifdef MTA_DEBUG
+            // T must be a pointer
+            void* ptr = (T)NULL;
+            ptr = NULL;
+        #endif
     }
 
     const T& front( void ) const

Shared/sdk/CScriptArgReader.h

@@ -51,7 +51,7 @@ class CScriptArgReader
         {
             lua_Number number = lua_tonumber(m_luaVM, m_iIndex++);
 
-            if (isnan(number))
+            if (std::isnan(number))
             {
                 SetCustomError("Expected number, got NaN", "Bad argument");
                 return;
@@ -77,7 +77,7 @@ class CScriptArgReader
         {
             lua_Number number = lua_tonumber(m_luaVM, m_iIndex++);
 
-            if (isnan(number))
+            if (std::isnan(number))
             {
                 SetCustomError("Expected number, got NaN", "Bad argument");
                 return;