0008193: Add possibility to clone ColShape

[emre1702]

You should be able to clone ColShapes with that.

Before someone asks why I didn't overload the "=" operator:
The CColManager-field is private (dunno why). Wasn't sure if I could make it public without any problems.
If it wouldn't be a problem, it's not really hard to change it.
Oh and I'm pretty new to C++, I think I could have overrided the copy constructor, too.

Oh and it's only tested in the server-console.
Got problems with joining in the game.

Bugtracker: https://bugs.mtasa.com/view.php?id=8193

[CrosRoad95]

people said that clone is buggy and should be disabled.
I dont think that clone is better then create new colshape, more usefull would be functions to modify existed colshapes

[emre1702]

Clone doesn't seem to be buggy for me, just not completed (oh and the bug that they won't get removed on resource stop got already fixed).
Cloning colshapes is the same as creating a new one, using same parent, same position, same height, same radius, same width, same dimension and same interior (oh and CustomDataPointer, dunno what that is).
So it's much shorter if you just want to create the same colshape on the same position.
Then you can change it a bit (move it a bit more right, in another dimension etc.).

O and the bug is marked as "confirmed" and in the roadmap for MTA 1.6.

[Citizen01]

(oh and CustomDataPointer, dunno what that is)

It's where all setElementData go and it is logical to duplicate it too:

local col1 = createColSphere(0, 0, 0, 10)
setElementData(col1, "price", 20)
local col2 = cloneElement(col1)
local price = getElementData(col2, "price")
-- Here 'price' should be equal to 20

Also I would add a break at the end of your CElement::COLSHAPE case.

[Samake]

Receiving cloned colshapes events of the original col too? This would be nice.

[Citizen01]

@Samake No, it is not cloning handlers of an event (if you were talking about that), and actually I think it should not. They are not cloned for other "clonable" element types like markers and pickups so one should expect the same behavior for the colshape type.

[emre1702]

@Citizen01 Thanks for both infos - fixed it.

[qaisjp]

Unfortunately we can't view the diff, and so we can't look into merging this. Do you have a backup @emre1702?

[emre1702]

No, better close.
Will work on it again.

[patrikjuvonen]

Waits for #182