Skip to content

Improve cloneElement #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Improve cloneElement #182

wants to merge 12 commits into from

Conversation

emre1702
Copy link
Contributor

@emre1702 emre1702 commented Dec 3, 2017 •
edited
Loading

Improvements:

  1. Use virtual clone function for the elements (as wanted in TODO comment in CStaticFunctionDefinitions.cpp)
  2. Created IsCloneable function for CElement
  3. CObject copy constructor improved & fixed (add type "object", copy alpha, scale, health, freeze, doublesided, breakable, syncable, syncer)
  4. Fixed IsSyncable() usage for CPed (used of new created CPed instead of the one element we want to clone)

@Necktrox Necktrox added enhancement New feature or request pr:needs-testing labels Dec 10, 2017
xerox8521
xerox8521 reviewed Mar 4, 2018
View reviewed changes
@patrikjuvonen patrikjuvonen mentioned this pull request Jul 26, 2018
Closed
@qaisjp qaisjp self-assigned this Sep 5, 2018
This was referenced Sep 5, 2018
Closed
Open
@qaisjp
Copy link
Contributor

qaisjp commented Sep 6, 2018

Stop deleting your repository @emre1702!

@qaisjp qaisjp added this to the 1.5.7 milestone Sep 6, 2018
@qaisjp
Copy link
Contributor

qaisjp commented Sep 6, 2018

I am working on this

@qaisjp
Copy link
Contributor

qaisjp commented Sep 6, 2018

This will auto close when next merges into master. Consider this merged.

@qaisjp qaisjp closed this in 960903e Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@xerox8521 xerox8521 xerox8521 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@qaisjp qaisjp

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.7
Development

Successfully merging this pull request may close these issues.
5 participants
@emre1702 @qaisjp @xerox8521 @Necktrox @botder