New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature for mapping. setWorldSpecialPropertyEnabled, `underworldwarp` property #208

Merged
merged 17 commits into from Jul 1, 2018

Conversation

Projects
6 participants
@CrosRoad95
Contributor

CrosRoad95 commented Jun 28, 2018

New property underworldwarp, by default: true.
If true then you can't fall under z -100.
if false then you can fall up to -5000.
Currently you can't build examples caves under z coordinate -100, this could be useful for mappers, mainly for DayZ servers.

Example test resource which allow to fall under map up to z = -5000 for peds and cars

setWorldSpecialPropertyEnabled("underworldwarp", false)

effect:
under map

Thanks for Saml1er and Octalype.

CrosRoad95 added some commits May 30, 2018

4
@Pirulax

This comment has been minimized.

Show comment
Hide comment
@Pirulax

Pirulax Jun 28, 2018

Contributor

In my option those commit messages aren't useful, next time please write some info about the commit into the commit message.

Contributor

Pirulax commented Jun 28, 2018

In my option those commit messages aren't useful, next time please write some info about the commit into the commit message.

@botder botder added the enhancement label Jun 29, 2018

@qaisjp qaisjp added the pr:tested label Jul 1, 2018

@qaisjp

This comment has been minimized.

Show comment
Hide comment
@qaisjp

qaisjp Jul 1, 2018

Member

Is there a reason why you would need only one of these functions and not always both? If not, please can you merge this into one function (in both game_sa and the Lua defs)?

Member

qaisjp commented Jul 1, 2018

Is there a reason why you would need only one of these functions and not always both? If not, please can you merge this into one function (in both game_sa and the Lua defs)?

@CrosRoad95

This comment has been minimized.

Show comment
Hide comment
@CrosRoad95

CrosRoad95 Jul 1, 2018

Contributor

Yes i can marge this two functions, do you have any good name for her?

Contributor

CrosRoad95 commented Jul 1, 2018

Yes i can marge this two functions, do you have any good name for her?

@ccw808

This comment has been minimized.

Show comment
Hide comment
@ccw808
Member

ccw808 commented Jul 1, 2018

@qaisjp

This comment has been minimized.

Show comment
Hide comment
@qaisjp

qaisjp Jul 1, 2018

Member

Yep, @CrosRoad95 I was going to move it into setWorldSpecialPropertyEnabled for you when merging, but you can do that instead, if you want!

I was going to go for PROP_UNDERWORLD_WARP and use the string "underworldwarp". Not sure about the name though.

Member

qaisjp commented Jul 1, 2018

Yep, @CrosRoad95 I was going to move it into setWorldSpecialPropertyEnabled for you when merging, but you can do that instead, if you want!

I was going to go for PROP_UNDERWORLD_WARP and use the string "underworldwarp". Not sure about the name though.

@CrosRoad95

This comment has been minimized.

Show comment
Hide comment
@CrosRoad95

CrosRoad95 Jul 1, 2018

Contributor

i will do it, only give me name of this property
today will be update, rewrited to work in setWorldSpecialPropertyEnabled function

Contributor

CrosRoad95 commented Jul 1, 2018

i will do it, only give me name of this property
today will be update, rewrited to work in setWorldSpecialPropertyEnabled function

@CrosRoad95 CrosRoad95 changed the title from Feature for mapping. set/getFallenPeds/CarsEnabled to Feature for mapping. setWorldSpecialPropertyEnabled, `underworldwarp` property Jul 1, 2018

@qaisjp

qaisjp approved these changes Jul 1, 2018

LGTM outside game_sa changes. Someone please merge if the game_sa changes are fine.

CrosRoad95 added some commits Jul 1, 2018

CrosRoad95 added some commits Jul 1, 2018

@ccw808 ccw808 merged commit 06300d5 into multitheftauto:master Jul 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

This was referenced Jul 1, 2018

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 7, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018

@patrikjuvonen patrikjuvonen moved this from In progress to Done in release/v1.5.6 Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment