-
-
Notifications
You must be signed in to change notification settings - Fork 488
Feature for mapping. setWorldSpecialPropertyEnabled, underworldwarp
property
#208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature for mapping. setWorldSpecialPropertyEnabled, underworldwarp
property
#208
Conversation
In my option those commit messages aren't useful, next time please write some info about the commit into the commit message. |
Is there a reason why you would need only one of these functions and not always both? If not, please can you merge this into one function (in both game_sa and the Lua defs)? |
Yes i can marge this two functions, do you have any good name for her? |
Just an idea, but what about using https://wiki.multitheftauto.com/wiki/SetWorldSpecialPropertyEnabled |
Yep, @CrosRoad95 I was going to move it into setWorldSpecialPropertyEnabled for you when merging, but you can do that instead, if you want! I was going to go for |
i will do it, only give me name of this property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside game_sa
changes. Someone please merge if the game_sa
changes are fine.
LUA_DECLARE(SetFallenPedsEnabled); | ||
LUA_DECLARE(SetFallenCarsEnabled); | ||
LUA_DECLARE(GetFallenPedsEnabled); | ||
LUA_DECLARE(GetFallenCarsEnabled); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these still needed?
Client/game_sa/CGameSA.h
Outdated
static float* VAR_TimeStep; | ||
static unsigned long* VAR_Framelimiter; | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
White space inconstancy
New property
underworldwarp
, by default: true.If
true
then you can't fall under z -100.if
false
then you can fall up to -5000.Currently you can't build examples caves under z coordinate -100, this could be useful for mappers, mainly for DayZ servers.
Example test resource which allow to fall under map up to z = -5000 for peds and cars
effect:

Thanks for Saml1er and Octalype.