Skip to content

Conversation

CrosRoad95
Copy link

@CrosRoad95 CrosRoad95 commented Jun 28, 2018

New property underworldwarp, by default: true.
If true then you can't fall under z -100.
if false then you can fall up to -5000.
Currently you can't build examples caves under z coordinate -100, this could be useful for mappers, mainly for DayZ servers.

Example test resource which allow to fall under map up to z = -5000 for peds and cars

setWorldSpecialPropertyEnabled("underworldwarp", false)

effect:
under map

Thanks for Saml1er and Octalype.

@Pirulax
Copy link
Contributor

Pirulax commented Jun 28, 2018

In my option those commit messages aren't useful, next time please write some info about the commit into the commit message.

@botder botder added the enhancement New feature or request label Jun 29, 2018
@qaisjp
Copy link
Contributor

qaisjp commented Jul 1, 2018

Is there a reason why you would need only one of these functions and not always both? If not, please can you merge this into one function (in both game_sa and the Lua defs)?

@CrosRoad95
Copy link
Author

Yes i can marge this two functions, do you have any good name for her?

@ccw808
Copy link
Member

ccw808 commented Jul 1, 2018

Just an idea, but what about using https://wiki.multitheftauto.com/wiki/SetWorldSpecialPropertyEnabled

@qaisjp
Copy link
Contributor

qaisjp commented Jul 1, 2018

Yep, @CrosRoad95 I was going to move it into setWorldSpecialPropertyEnabled for you when merging, but you can do that instead, if you want!

I was going to go for PROP_UNDERWORLD_WARP and use the string "underworldwarp". Not sure about the name though.

@CrosRoad95
Copy link
Author

CrosRoad95 commented Jul 1, 2018

i will do it, only give me name of this property
today will be update, rewrited to work in setWorldSpecialPropertyEnabled function

Copy link
Contributor

@qaisjp qaisjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside game_sa changes. Someone please merge if the game_sa changes are fine.

LUA_DECLARE(SetFallenPedsEnabled);
LUA_DECLARE(SetFallenCarsEnabled);
LUA_DECLARE(GetFallenPedsEnabled);
LUA_DECLARE(GetFallenCarsEnabled);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these still needed?

static float* VAR_TimeStep;
static unsigned long* VAR_Framelimiter;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

White space inconstancy

@ccw808 ccw808 merged commit 06300d5 into multitheftauto:master Jul 1, 2018
@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants