New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getElementBoundingBox() OOP version returning 6 numbers instead of a 2 vectors #305

Merged
merged 8 commits into from Aug 10, 2018

Conversation

Projects
4 participants
@Pirulax
Contributor

Pirulax commented Aug 6, 2018

Small'n'Easy to test.
Fixes the OOP version of getElementBoudingBox.

  1. Now it returns 2 vectors if MinClientReqCheck passed
  2. Now it's available as a class variable too
@Pirulax

This comment has been minimized.

Show comment
Hide comment
@Pirulax

Pirulax Aug 6, 2018

Contributor

Also, please see the header file, I left a comment there, please help me out with that :)

Contributor

Pirulax commented Aug 6, 2018

Also, please see the header file, I left a comment there, please help me out with that :)

@patrikjuvonen patrikjuvonen added this to In progress in release/v1.5.6 via automation Aug 6, 2018

@patrikjuvonen patrikjuvonen added the bug label Aug 6, 2018

@patrikjuvonen patrikjuvonen added this to the 1.5.6 milestone Aug 6, 2018

@Addlibs

This comment has been minimized.

Show comment
Hide comment
@Addlibs

Addlibs Aug 6, 2018

Contributor

I think the 510990e (min_mta_version tag in meta) solution is more elegant than a bool argument for legacy style

Contributor

Addlibs commented Aug 6, 2018

I think the 510990e (min_mta_version tag in meta) solution is more elegant than a bool argument for legacy style

release/v1.5.6 automation moved this from In progress to Ready Aug 7, 2018

@patrikjuvonen

This comment has been minimized.

Show comment
Hide comment
@patrikjuvonen

patrikjuvonen Aug 7, 2018

Collaborator

Reminder for committer: MIN_CLIENT_REQ_GETBOUNDINGBOX_OOP needs to be bumped before merge.

Collaborator

patrikjuvonen commented Aug 7, 2018

Reminder for committer: MIN_CLIENT_REQ_GETBOUNDINGBOX_OOP needs to be bumped before merge.

Pirulax added some commits Aug 8, 2018

@patrikjuvonen patrikjuvonen moved this from Ready to In progress in release/v1.5.6 Aug 8, 2018

qaisjp added some commits Aug 10, 2018

@qaisjp qaisjp merged commit 6ac18eb into multitheftauto:master Aug 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details

release/v1.5.6 automation moved this from In progress to Done Aug 10, 2018

@qaisjp

This comment has been minimized.

Show comment
Hide comment
@qaisjp

qaisjp Aug 10, 2018

Member

Thank you!

Member

qaisjp commented Aug 10, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment