Backward compatibility fix for OOP_GetElementBoundingBox returning vectors post-r13998 #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qaisjp
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
lgtm but requesting a review from @patrikjuvonen as he reviewed the previous PR
|
I should've been more explicit on what I reviewed in the previous PR. I only reviewed the part he requested to be commented on, I wasn't reviewing the whole PR. It will take me a while to get to this PR but I'll keep this PR in mind. |
|
Oh okay. No problem. In that case am I okay to dismiss your review request? |
|
Feel free to dismiss my review request. My apologies for any inconvenience. |
|
don't worry about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #305 was merged, getBoundingBox OOP method started returning vectors in old code when run on the new client, instead of returning 6 floats as was previously the case.
The backward compatibility check was inverted, as the function returned the 6 legacy floats if min_mta_version was higher than r13999 where it should do so only if it was lower. Additionally, it lacked any warnings or info about this change in behaviour.
This PR fixes MinClientReqCheck which was wrong way round in OOP_GetElementBoundingBox.
It also adds a warning on the server console about modified functionality after 1.5.5-9.13999, consistent with getComponentPosition and getComponentRotation OOP return modifications.
New behaviour:
OOP getBoundingBox() method will continue to return 6 floats unless min_mta_version client is set to 1.5.5-9.13999 or higher in the meta.xml, in which case it'll return vectors