Skip to content

Type Object and quotation mark edits #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Type Object and quotation mark edits #246

wants to merge 1 commit into from

Conversation

Lauren-Bee
Copy link
Contributor

This pull request includes:

  • Proofreading edits to the Type Object chapter
  • A few minor fixes to the Introduction and Double Buffer chapters to move punctuation that appeared inside quotation marks outside of the quotation marks (unless it was part of the quoted matter) in other chapters
  • An update to the style guide to define the quote/punctuation convention

Proofreading edits to the Type Object chapter, a few minor fixes to move
punctuation that appeared inside quotation marks outside of the
quotation marks (unless it was part of the quoted matter), and an update
to the style guide.
@munificent
Copy link
Owner

Thanks! I merged this in, but not in the right way to get Git to realize that. (Some snafu on my part.)

Your changes to punctuation are good ones. I'd been meaning to do something about that for a while, but wasn't sure which quotation style to go with. I like your choice.

@munificent munificent closed this Jul 27, 2014
@Lauren-Bee
Copy link
Contributor Author

Thank you for letting me know! I will be extra careful when pulling from
your repository to make sure mine is up-to-date when I start editing.

On Sun, Jul 27, 2014 at 12:31 PM, Bob Nystrom notifications@github.com
wrote:

Thanks! I merged this in, but not in the right way to get Git to realize
that. (Some snafu on my part.)

Your changes to punctuation are good ones. I'd been meaning to do
something about that for a while, but wasn't sure which quotation style to
go with. I like your choice.


Reply to this email directly or view it on GitHub
#246 (comment)
.

@munificent
Copy link
Owner

Don'y worry, your pull request was perfectly fine. I screwed up on my end. :)

@Lauren-Bee
Copy link
Contributor Author

Phew! :) I figured as long as the only files with updates were the ones I
actually intended to update, it would be okay!

On Tue, Jul 29, 2014 at 10:29 AM, Bob Nystrom notifications@github.com
wrote:

Don'y worry, your pull request was perfectly fine. I screwed up on my end.
:)


Reply to this email directly or view it on GitHub
#246 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants