Change the cast targets #2650
Closed
Change the cast targets #2650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harawata
requested changes
Aug 14, 2022
There was a problem hiding this comment.
Thank you for the PR, @IrvingOS !
The code is implemented against Weak/SoftReference, so we should not use the subclasses here.
You should be able to remove @SuppressWarning by using the wild card. e.g. SoftReference<?>
FYI, you can update this PR by adding/pushing new commits to the same branch.
|
Thanks so much for your early reply, @harawata . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WeakReference<Object>toWeakEntryinWeakCache.class.SoftReference<Object>toSoftEntryinSoftCache.class.Because I don't think it's necessary to convert
delegate.get(key)toWeakReferenceorSoftReferenceand then suppress the warning with@SuppressWarnings("unchecked").If my idea is wrong, please point it out.
Thanks!