Skip to content

Change the cast targets #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change the cast targets #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/org/apache/ibatis/cache/decorators/SoftCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ public void putObject(Object key, Object value) {
@Override
public Object getObject(Object key) {
Object result = null;
@SuppressWarnings("unchecked") // assumed delegate cache is totally managed by this cache
SoftReference<Object> softReference = (SoftReference<Object>) delegate.getObject(key);
// assumed delegate cache is totally managed by this cache
SoftEntry softReference = (SoftEntry) delegate.getObject(key);
if (softReference != null) {
result = softReference.get();
if (result == null) {
Expand All @@ -87,8 +87,7 @@ public Object getObject(Object key) {
@Override
public Object removeObject(Object key) {
removeGarbageCollectedItems();
@SuppressWarnings("unchecked")
SoftReference<Object> softReference = (SoftReference<Object>) delegate.removeObject(key);
SoftEntry softReference = (SoftEntry) delegate.removeObject(key);
return softReference == null ? null : softReference.get();
}

Expand Down
7 changes: 3 additions & 4 deletions src/main/java/org/apache/ibatis/cache/decorators/WeakCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ public void putObject(Object key, Object value) {
@Override
public Object getObject(Object key) {
Object result = null;
@SuppressWarnings("unchecked") // assumed delegate cache is totally managed by this cache
WeakReference<Object> weakReference = (WeakReference<Object>) delegate.getObject(key);
// assumed delegate cache is totally managed by this cache
WeakEntry weakReference = (WeakEntry) delegate.getObject(key);
if (weakReference != null) {
result = weakReference.get();
if (result == null) {
Expand All @@ -86,8 +86,7 @@ public Object getObject(Object key) {
@Override
public Object removeObject(Object key) {
removeGarbageCollectedItems();
@SuppressWarnings("unchecked")
WeakReference<Object> weakReference = (WeakReference<Object>) delegate.removeObject(key);
WeakEntry weakReference = (WeakEntry) delegate.removeObject(key);
return weakReference == null ? null : weakReference.get();
}

Expand Down