New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge typehandlers-jsr310 into the core. #974

Merged
merged 3 commits into from May 24, 2017

Conversation

Projects
None yet
4 participants
@harawata
Member

harawata commented Apr 11, 2017

typehandlers-jsr310 are for standard Java types and they belong to the core in the first place.
We didn't know how to include them in the core without breaking Java 6 compatibility, but we do now.
So I propose to merge them into the core.
It might be a little bit confusing at first, but I cannot think of any serious issue caused by this change.

Any thoughts?

Cc-ing: @emacarron @hazendaz @kazuki43zoo @trohovsky @raupachz

harawata referenced this pull request Apr 11, 2017

@kazuki43zoo

Hi @harawata, There is no objection with your proposal(It's great proposal). But I do not understand a mechanism to resolve for code that depends on different JDK versions on compile time yet... Could you explain it ? (The mechanism for test code is understanding already!)

And I've added some trivial comments.

@raupachz

This comment has been minimized.

Show comment
Hide comment
@raupachz

raupachz Apr 12, 2017

Why don't you check System.getProperty("java.version");?

raupachz commented Apr 12, 2017

Why don't you check System.getProperty("java.version");?

@harawata

This comment has been minimized.

Show comment
Hide comment
@harawata

harawata Apr 12, 2017

Member

Thank you guys for the comments! =)

@kazuki43zoo ,
I'll update the files later.

@raupachz ,
The logic based on version string potentially causes an issue like this and should be avoided, IMHO.
As a related topic, the version string schema change in Java 9 might break some existing apps/libraries that rely on the old schema, I imagine.

Member

harawata commented Apr 12, 2017

Thank you guys for the comments! =)

@kazuki43zoo ,
I'll update the files later.

@raupachz ,
The logic based on version string potentially causes an issue like this and should be avoided, IMHO.
As a related topic, the version string schema change in Java 9 might break some existing apps/libraries that rely on the old schema, I imagine.

@raupachz

This comment has been minimized.

Show comment
Hide comment
@raupachz

raupachz Apr 12, 2017

@harawata Ah, I see. Was just a suggestion. Probably all a matter of personal preference. Like most things.

raupachz commented Apr 12, 2017

@harawata Ah, I see. Was just a suggestion. Probably all a matter of personal preference. Like most things.

@harawata

This comment has been minimized.

Show comment
Hide comment
@harawata

harawata Apr 12, 2017

Member

@raupachz ;D Any suggestion is welcome!

Member

harawata commented Apr 12, 2017

@raupachz ;D Any suggestion is welcome!

Merge branch 'master' into merge-typehandlers-jsr310
# Conflicts:
#	src/test/java/org/apache/ibatis/type/usesjava8/Jsr310TypeHandlerRegistryTest.java
@hazendaz

This comment has been minimized.

Show comment
Hide comment
@hazendaz
Member

hazendaz commented May 24, 2017

+1

@harawata harawata merged commit a0308b1 into mybatis:master May 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kazuki43zoo kazuki43zoo added this to the 3.4.5 milestone Jun 7, 2017

kazuki43zoo added a commit that referenced this pull request Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment