Skip to content

Fix join condition for retrieval of imported primary keys #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix join condition for retrieval of imported primary keys #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/user-impl/java/com/mysql/cj/jdbc/DatabaseMetaDataUsingInfoSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ public java.sql.ResultSet getImportedKeys(String catalog, String schema, String
sqlBuf.append(" AS DELETE_RULE, A.CONSTRAINT_NAME AS FK_NAME, R.UNIQUE_CONSTRAINT_NAME AS PK_NAME,");
sqlBuf.append(importedKeyNotDeferrable);
sqlBuf.append(" AS DEFERRABILITY FROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE A");
sqlBuf.append(" JOIN INFORMATION_SCHEMA.TABLE_CONSTRAINTS B USING (CONSTRAINT_NAME, TABLE_NAME) ");
sqlBuf.append(" JOIN INFORMATION_SCHEMA.TABLE_CONSTRAINTS B USING (CONSTRAINT_SCHEMA, CONSTRAINT_NAME, TABLE_NAME) ");
sqlBuf.append(generateOptionalRefContraintsJoin());
sqlBuf.append("WHERE B.CONSTRAINT_TYPE = 'FOREIGN KEY'");
if (db != null) {
Expand Down
85 changes: 85 additions & 0 deletions src/test/java/testsuite/regression/MetaDataRegressionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5548,4 +5548,89 @@ void testBug109808() throws Exception {
} while (useIS = !useIS);
}

/**
* Tests fix for Bug#108088, DatabaseMetaData.getImportedKeys can return foreign keys from wrong schema.
*
* @throws Exception
*/
@Test
public void testBug108088() throws Exception {
String databaseName1 = "dbBug108088_1";
String databaseName2 = "dbBug108088_2";
if (isServerRunningOnWindows()) {
databaseName1 = databaseName1.toLowerCase();
databaseName2 = databaseName2.toLowerCase();
}
String tableName1 = "table1";
String tableName2 = "table2";
String constraintName = "fk_table2_fk_id";

createDatabase(databaseName1);
createTable(databaseName1 + "." + tableName1, "(`ID` bigint unsigned AUTO_INCREMENT PRIMARY KEY)");
createTable(databaseName1 + "." + tableName2,
"(`ID` bigint unsigned AUTO_INCREMENT PRIMARY KEY, `FK_ID` bigint unsigned NOT NULL,"
+ "CONSTRAINT `" + constraintName + "` FOREIGN KEY (`FK_ID`) REFERENCES `"
+ databaseName1 + "`.`" + tableName1 + "` (`ID`) ON DELETE CASCADE)");
createDatabase(databaseName2);
createTable(databaseName2 + "." + tableName1, "(`ID` bigint unsigned AUTO_INCREMENT PRIMARY KEY)");
createTable(databaseName2 + "." + tableName2,
"(`ID` bigint unsigned AUTO_INCREMENT PRIMARY KEY, `FK_ID` bigint unsigned NOT NULL,"
+ "CONSTRAINT `" + constraintName + "` FOREIGN KEY (`FK_ID`) REFERENCES `"
+ databaseName2 + "`.`" + tableName1 + "` (`ID`) ON DELETE RESTRICT)");

Properties props = new Properties();
props.setProperty(PropertyKey.sslMode.getKeyName(), SslMode.DISABLED.name());
props.setProperty(PropertyKey.allowPublicKeyRetrieval.getKeyName(), "true");
for (boolean useIS : new boolean[] { false, true }) {
for (String databaseTerm : new String[] { "CATALOG", "SCHEMA" }) {
props.setProperty(PropertyKey.useInformationSchema.getKeyName(), "" + useIS);
props.setProperty(PropertyKey.databaseTerm.getKeyName(), databaseTerm);

boolean dbTermIsSchema = databaseTerm.equals("SCHEMA");

String err = "useInformationSchema=" + useIS + ", databaseTerm=" + databaseTerm;
Connection con = getConnectionWithProps(props);
DatabaseMetaData meta = con.getMetaData();

this.rs = dbTermIsSchema ? meta.getImportedKeys(null, databaseName1, tableName2) : meta.getImportedKeys(databaseName1, null, tableName2);
assertTrue(this.rs.next(), err);
assertEquals(dbTermIsSchema ? "def" : databaseName1, this.rs.getString("PKTABLE_CAT"), err);
assertEquals(dbTermIsSchema ? databaseName1 : null, this.rs.getString("PKTABLE_SCHEM"), err);
assertEquals(dbTermIsSchema ? "def" : databaseName1, this.rs.getString("FKTABLE_CAT"), err);
assertEquals(dbTermIsSchema ? databaseName1 : null, this.rs.getString("FKTABLE_SCHEM"), err);
assertEquals(tableName1, this.rs.getString("PKTABLE_NAME"), err);
assertEquals("ID", this.rs.getString("PKCOLUMN_NAME"), err);
assertEquals(tableName2, this.rs.getString("FKTABLE_NAME"), err);
assertEquals("FK_ID", this.rs.getString("FKCOLUMN_NAME"), err);
assertEquals(1, this.rs.getInt("KEY_SEQ"), err);
assertEquals(1, this.rs.getInt("UPDATE_RULE"), err);
assertEquals(0, this.rs.getInt("DELETE_RULE"), err);
assertEquals(constraintName, this.rs.getString("FK_NAME"), err);
assertEquals(useIS ? "PRIMARY" : null, this.rs.getString("PK_NAME"), err);
assertEquals(7, this.rs.getInt("DEFERRABILITY"), err);
assertFalse(this.rs.next(), err);

this.rs = dbTermIsSchema ? meta.getImportedKeys(null, databaseName2, tableName2) : meta.getImportedKeys(databaseName2, null, tableName2);
assertTrue(this.rs.next(), err);
assertEquals(dbTermIsSchema ? "def" : databaseName2, this.rs.getString("PKTABLE_CAT"), err);
assertEquals(dbTermIsSchema ? databaseName2 : null, this.rs.getString("PKTABLE_SCHEM"), err);
assertEquals(dbTermIsSchema ? "def" : databaseName2, this.rs.getString("FKTABLE_CAT"), err);
assertEquals(dbTermIsSchema ? databaseName2 : null, this.rs.getString("FKTABLE_SCHEM"), err);
assertEquals(tableName1, this.rs.getString("PKTABLE_NAME"), err);
assertEquals("ID", this.rs.getString("PKCOLUMN_NAME"), err);
assertEquals(tableName2, this.rs.getString("FKTABLE_NAME"), err);
assertEquals("FK_ID", this.rs.getString("FKCOLUMN_NAME"), err);
assertEquals(1, this.rs.getInt("KEY_SEQ"), err);
assertEquals(1, this.rs.getInt("UPDATE_RULE"), err);
assertEquals(1, this.rs.getInt("DELETE_RULE"), err);
assertEquals(constraintName, this.rs.getString("FK_NAME"), err);
assertEquals(useIS ? "PRIMARY" : null, this.rs.getString("PK_NAME"), err);
assertEquals(7, this.rs.getInt("DEFERRABILITY"), err);
assertFalse(this.rs.next(), err);

con.close();
}
}
}

}