Skip to content

Improve minPool size strategy to detect the maximun used connections … #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Improve minPool size strategy to detect the maximun used connections … #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions Source/MySql.Data/MySqlPool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ internal sealed class MySqlPool
private bool beingCleared;
private int available;
private AutoResetEvent autoEvent;
private int maxUsedConnections;

private void EnqueueIdle(Driver driver)
{
Expand All @@ -63,6 +64,7 @@ public MySqlPool(MySqlConnectionStringBuilder settings)
inUsePool = new List<Driver>((int)maxSize);
idlePool = new Queue<Driver>((int)maxSize);

maxUsedConnections = (int)minSize;
// prepopulate the idle pool to minSize
for (int i = 0; i < minSize; i++)
EnqueueIdle(CreateNewPooledConnection());
Expand Down Expand Up @@ -158,6 +160,9 @@ private Driver GetPooledConnection()
lock ((inUsePool as ICollection).SyncRoot)
{
inUsePool.Add(driver);
int currentlyInUse = inUsePool.Count;
if (currentlyInUse > maxUsedConnections)
maxUsedConnections = currentlyInUse;
}
return driver;
}
Expand Down Expand Up @@ -227,6 +232,7 @@ public void RemoveConnection(Driver driver)
private Driver TryToGetDriver()
{
int count = Interlocked.Decrement(ref available);

if (count < 0)
{
Interlocked.Increment(ref available);
Expand Down Expand Up @@ -310,21 +316,14 @@ internal List<Driver> RemoveOldIdleConnections()
// The drivers appear to be ordered by their age, i.e it is
// sufficient to remove them until the first element is not
// too old.
while (idlePool.Count > minSize)
int targetSize = minSize > maxUsedConnections ? (int)minSize : maxUsedConnections;
while (idlePool.Count > targetSize)
{
Driver d = idlePool.Peek();
DateTime expirationTime = d.IdleSince.Add(
new TimeSpan(0, 0, MySqlPoolManager.maxConnectionIdleTime));
if (expirationTime.CompareTo(now) < 0)
{
oldDrivers.Add(d);
idlePool.Dequeue();
}
else
{
break;
}
oldDrivers.Add(d);
idlePool.Dequeue();
}
maxUsedConnections = (int)minSize;
}
return oldDrivers;
}
Expand Down