[Bug #111630]Add support for BigEndian clients in MySQL.Data #54
Conversation
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
/covered |
|
Can anyone start the review please ? |
|
@davaldezr . Can some review this ? |
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
|
@mysql-admin The OCA is signed, can you please confirm it and reopen the PR? |
|
Reopening to continue processing Thanks for contributing to MySQL |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
/covered |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
BitConverter methods used in classes defined under the MySqlClient namespace inherently check for the endianness of the client system which leads to incorrect reads of incoming MySql packets sent by the server for BigEndian client machines. Implemented a PacketBitConverter class to read incoming packets in LittleEndian order always. BitConverter.ToString is unchanged since string values are read byte by byte. BitConverter used in packages like NetworkStream and CompressedStream should not be replaced as it interfaces with network libraries. Signed-off-by: Sidraya <sidraya.jayagond@ibm.com>
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
|
@mysql-admin Hi, can we get the status on the PR by the verification team? |
|
Hi @saitama951 , |
BitConverter methods used in classes defined under the MySqlClient namespace inherently check for the endianness of the client system which leads to incorrect reads of incoming MySql packets sent by the server for BigEndian client machines.
Implemented a PacketBitConverter class to read incoming packets in LittleEndian order always.
BitConverter.ToString is unchanged since string values are read byte by byte.
BitConverter used in packages like NetworkStream and CompressedStream should not be replaced as it interfaces with network libraries.