Skip to content

Fixed an issue with a multi-threaded environment. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed an issue with a multi-threaded environment. #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions MySQL.Data/src/MySqlPoolManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ namespace MySql.Data.MySqlClient
/// </summary>
internal class MySqlPoolManager
{
private static readonly Dictionary<string, MySqlPool> Pools = new Dictionary<string, MySqlPool>();
private static readonly ConcurrentDictionary<string, MySqlPool> Pools = new ConcurrentDictionary<string, MySqlPool>();
private static readonly List<MySqlPool> ClearingPools = new List<MySqlPool>();
internal const int DEMOTED_TIMEOUT = 120000;

Expand Down Expand Up @@ -146,7 +146,7 @@ public static async Task<MySqlPool> GetPoolAsync(MySqlConnectionStringBuilder se
if (pool == null)
{
pool = await MySqlPool.CreateMySqlPoolAsync(settings, execAsync, cancellationToken).ConfigureAwait(false);
Pools.Add(text, pool);
Pools.TryAdd(text, pool);
}
else
pool.Settings = settings;
Expand Down Expand Up @@ -207,7 +207,7 @@ private static async Task ClearPoolByTextAsync(string key, bool execAsync)
await pool.ClearAsync(execAsync).ConfigureAwait(false);

// and then remove the pool from the active pools list
Pools.Remove(key);
Pools.TryRemove(key, out MySqlPool mySqlPool);

semaphoreSlim.Release();
}
Expand Down