refactor(iroh): add --start option to CLI commands
#1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
feat-cli-start
branch
2 times, most recently
from
5bab7f9
to
c598523
Compare
Frando
force-pushed
the
feat-cli-start
branch
from
c598523
to
18b36d0
Compare
|
/netsim branch arqu/fixcli |
|
If this passes (which is expected) https://github.com/n0-computer/iroh/actions/runs/6889635559/job/18741024267 |
2 tasks
looks like it is not passing |
## Description Changes for #1802 CLI command changes: * `iroh start` takes `--add` not `--source` * `iroh blob add` takes required `SOURCE` arg and not optional `--source` opt Internal changes: * reduce code duplication around starting a node * always start the metrics server (for both `iroh start` and `iroh CMD --start`) * make sure to remove the rpc lock file if aborting with error * cleanups ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - ~~[ ] Tests if relevant.~~
|
/netsim branch frando/fixcli edit: runs here https://github.com/n0-computer/iroh/actions/runs/6902564336 |
|
/netsim branch frando/fixcli |
|
/netsim branch frando/fixcli |
4 similar comments
|
/netsim branch frando/fixcli |
|
/netsim branch frando/fixcli |
|
/netsim branch frando/fixcli |
|
/netsim branch frando/fixcli |
|
/netsim branch frando/fixcli |
|
/netsim branch frando/fixcli |
|
/netsim branch frando/fixcli |
1 similar comment
|
/netsim branch frando/fixcli |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to CLI commands:
--startoption that starts a node, runs the command, and then shuts down the nodeiroh getis nowiroh blob get, and needs--startflag to run standaloneiroh start SOURCEis nowiroh start --add SOURCENotes and open questions
We could remove the
--add SOURCEoption fromiroh startif there was a way to to keep running the node after starting it with a command. Could also be something like an--execoption. But let's leave that to a followup.