New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve code and args for CLI start #1812

Merged

Frando merged 3 commits into feat-cli-start from feat-cli-start-improve-start

Nov 16, 2023

Member

Frando commented Nov 16, 2023 •

edited

Loading

Description

Changes for #1802

CLI command changes:

iroh start takes --add not --source
iroh blob add takes required SOURCE arg and not optional --source opt

Internal changes:

reduce code duplication around starting a node
always start the metrics server (for both iroh start and iroh CMD --start)
make sure to remove the rpc lock file if aborting with error
cleanups

Notes & open questions

Change checklist

Self-review.
Documentation updates if relevant.
~~[ ] Tests if relevant.~~


          refactor: improve start code and args

dad843f

Frando changed the base branch from main to feat-cli-start

November 16, 2023 10:48


          fix: cli tests

3d1c816

dignifiedquire approved these changes

View reviewed changes

Contributor

dignifiedquire left a comment

very nice


          chore: clippy & cleanup

dac462c

Frando merged commit f925af0 into feat-cli-start

14 of 15 checks passed

dignifiedquire deleted the feat-cli-start-improve-start branch

November 16, 2023 13:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet