Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error on too many rows #8334

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error on too many rows #8334

merged 1 commit into from
Jan 15, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 15, 2024

Array de-structuring combined with .push( on an array of 120k items is always going push the stack beyond it's max size. This is why why we should avoid this pattern whenever possible.

We've already had to fix this exact same issue for the Google Sheets Node in #7384

Related tickets and issues

Fixes #8333

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jan 15, 2024
Joffcom
Joffcom approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good so if user test works I am happy.

@cypress Cypress
Copy link

cypress bot commented Jan 15, 2024

1 flaky test on run #3764 ↗︎

0 331 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 732ccd0a2b
Status: Passed Duration: 03:21 💡
Started: Jan 15, 2024 2:42 PM Ended: Jan 15, 2024 2:46 PM
Flakiness  cypress/e2e/28-debug.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Debug > should be able to debug executions Test Replay Screenshots Video

Review all test suite changes for PR #8334 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit bb2be8d into master Jan 15, 2024
28 checks passed
@netroy netroy deleted the fix-NODE-1052 branch January 15, 2024 16:52
netroy added a commit that referenced this pull request Jan 16, 2024
@netroy
fix(Microsoft SQL Node): Fix "Maximum call stack size exceeded" error…
61cabb6 
… on too many rows (#8334)
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Merged
@janober
Copy link
Member

janober commented Jan 16, 2024

Got released with n8n@1.24.1

@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Merged
netroy added a commit that referenced this pull request Feb 1, 2024
@netroy
fix(MongoDB Node): Fix "Maximum call stack size exceeded" error on to…
29b7c71 
…o many rows

Previous similar fixes:

* Google Sheets Node #7384
* Microsoft SQL Node #8334
@netroy netroy mentioned this pull request Feb 1, 2024
Merged
1 task
@netroy netroy mentioned this pull request Feb 16, 2024
Merged
1 task
@netroy netroy mentioned this pull request Sep 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft SQL - Maximum call stack size exceeded
3 participants
@netroy @janober @Joffcom