fix(core): Improve axios error handling in nodes #5664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
netroy
commented
Mar 10, 2023
|
|
||
| constructor( | ||
| node: INode, | ||
| error: JsonObject, | ||
| { message, description, httpCode, parseXml, runIndex, itemIndex }: NodeApiErrorOptions = {}, | ||
| ) { | ||
| if (error.reason instanceof NodeApiError) return error.reason; |
There was a problem hiding this comment.
this should be a separate PR. The issue this is solving is of us accidentally wrapping NodeApiError instances with new NodeApiError. This is what causes a lot of the "Unknown error" in the frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.