Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Loop Over Items (Split in Batches) Node): Automatically add a loop + rename #7228

Merged
merged 16 commits into from Oct 6, 2023
Merged

feat(Loop Over Items (Split in Batches) Node): Automatically add a loop + rename #7228

merged 16 commits into from Oct 6, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 21, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023 •
edited

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/views/NodeView.vue:

  • Avoided adding code here. Only refactored to make it smaller.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@elsmr elsmr changed the title Automatically add a loop with the Split In Batches Node + rename feat(Loop Over Items Node): Automatically add a loop + rename (from Split In Batches) Sep 21, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node ui Enhancement in /editor-ui or /design-system labels Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited

Codecov Report

Attention: 202 lines in your changes are missing coverage. Please review.

Comparison is base (cd12a59) 33.43% compared to head (d50a668) 33.47%.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7228      +/-   ##
==========================================
+ Coverage   33.43%   33.47%   +0.04%     
==========================================
  Files        3378     3379       +1     
  Lines      206089   206193     +104     
  Branches    22238    22254      +16     
==========================================
+ Hits        68897    69017     +120     
+ Misses     136074   136058      -16     
  Partials     1118     1118
Files Coverage Δ
packages/editor-ui/src/Interface.ts 100.00% <100.00%> (ø)
.../components/Node/NodeCreator/Modes/ActionsMode.vue 100.00% <100.00%> (ø)
packages/editor-ui/src/constants.ts 99.68% <100.00%> (+<0.01%) ⬆️
...s-base/nodes/SplitInBatches/SplitInBatches.node.ts 100.00% <100.00%> (ø)
...rc/components/Node/NodeCreator/Modes/NodesMode.vue 59.66% <0.00%> (+0.40%) ⬆️
packages/cli/src/license/license.controller.ts 77.58% <33.33%> (-2.42%) ⬇️
...components/Node/NodeCreator/ItemTypes/NodeItem.vue 76.00% <75.00%> (+0.43%) ⬆️
...mponents/Node/NodeCreator/ItemTypes/ActionItem.vue 69.03% <40.00%> (ø)
...ponents/Node/NodeCreator/composables/useActions.ts 50.92% <95.31%> (+23.39%) ⬆️
...ui/src/components/Node/NodeCreator/NodeCreator.vue 0.00% <0.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-radency
michael-radency previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

turbo.json Show resolved Hide resolved
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Sep 21, 2023 •
edited

1 flaky test on run #2416 ↗︎

0 247 3 0 Flakiness 1

Details:

🌳 node-792-split-in-batches-improve 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr...
Project: n8n Commit: d50a66851b
Status: Passed Duration: 08:22 💡
Started: Oct 6, 2023 1:07 PM Ended: Oct 6, 2023 1:16 PM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Output Screenshots Video

Review all test suite changes for PR #7228 ↗︎

mutdmour
mutdmour requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Can you please make sure to add tests for this new feature?

mutdmour
mutdmour reviewed Sep 27, 2023
View reviewed changes
packages/editor-ui/src/views/NodeView.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/views/NodeView.vue Outdated Show resolved Hide resolved
packages/editor-ui/src/views/NodeView.vue Outdated Show resolved Hide resolved
@elsmr elsmr changed the title feat(Loop Over Items Node): Automatically add a loop + rename (from Split In Batches) feat(Loop Over Items (Split In Batches) Node): Automatically add a loop + rename (from Split In Batches) Oct 4, 2023
@elsmr elsmr changed the title feat(Loop Over Items (Split In Batches) Node): Automatically add a loop + rename (from Split In Batches) feat(Loop Over Items (Split In Batches) Node): Automatically add a loop + rename Oct 4, 2023
@elsmr elsmr changed the title feat(Loop Over Items (Split In Batches) Node): Automatically add a loop + rename feat(Loop Over Items (Split in Batches) Node): Automatically add a loop + rename Oct 4, 2023
mutdmour
mutdmour reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback. Please pull master before continuing.

packages/editor-ui/src/views/NodeView.vue Show resolved Hide resolved
packages/editor-ui/src/components/Node/NodeCreator/composables/useActions.ts Show resolved Hide resolved
cypress/e2e/4-node-creator.cy.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/components/Node/NodeCreation.vue Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

mutdmour
mutdmour previously approved these changes Oct 5, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 7b773cc into master Oct 6, 2023
79 of 81 checks passed
@elsmr elsmr deleted the node-792-split-in-batches-improve branch October 6, 2023 13:31
krynble pushed a commit that referenced this pull request Oct 11, 2023
@elsmr @michael-radency @krynble
feat(Loop Over Items (Split in Batches) Node): Automatically add a lo…
ea877c1 
…op + rename (#7228)

Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Merged
krynble added a commit that referenced this pull request Oct 11, 2023
@github-actions @krynble
🚀 Release 1.10.1 (#7397)
e45d04c 
##
[1.10.1](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.10.1)
(2023-10-11)


### Bug Fixes

* **editor:** Make workflow history button available only for dev builds
([#7392](#7392))
([f2a7b41](f2a7b41))


### Features

* **Loop Over Items (Split in Batches) Node:** Automatically add a loop
+ rename ([#7228](#7228))
([ea877c1](ea877c1))

Co-authored-by: krynble <krynble@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Merged
netroy added a commit that referenced this pull request Oct 11, 2023
@github-actions @netroy
🚀 Release 1.11.0 (#7402)
e6ba841 
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0)
(2023-10-11)


### Bug Fixes

* **core:** Add an option to enable postgres ssl with default certs
([#6889](#6889))
([789e1e7](789e1e7))
* **core:** Fix error on missing paired item data
([#7399](#7399))
([47e8953](47e8953))
* **core:** Missing pairing info
([#7326](#7326))
([e2c3c7a](e2c3c7a))
* **core:** Prevent object deletion request on no prefix match
([#7366](#7366))
([63e11e4](63e11e4))
* **editor:** Fix completions for `.json` on quoted node name in Code
node ([#7382](#7382))
([86e7ec7](86e7ec7))
* **editor:** Implement canvas zoom UX improvements
([#7376](#7376))
([7e06b31](7e06b31))
* **editor:** Make workflow history button available only for dev builds
([#7392](#7392))
([7ed466d](7ed466d))
* **editor:** Remove excess margin below run data editor
([#7372](#7372))
([3fa2764](3fa2764))
* **editor:** Sanitize HTML binary-data before rendering in the UI
([#7400](#7400))
([2b075bf](2b075bf))
* **editor:** Use display option's @Version specifier
([#7351](#7351))
([afbf0c3](afbf0c3))
* **Google BigQuery Node:** Location default to jobReference
([#7354](#7354))
([97bb703](97bb703))
* **Google Drive Trigger Node:** Add Shared Drives support
([#7369](#7369))
([3e7a4d3](3e7a4d3))
* **Google Sheets Node:** Fix "Maximum call stack size exceeded" error
on too many rows ([#7384](#7384))
([732b15a](732b15a))
* **HTML Node:** Update property fields to not use expressions on drag
([#7379](#7379))
([77643e5](77643e5))
* **Notion Node:** Handle empty values correctly for Notion selects +
multi selects ([#7383](#7383))
([fbcd1d4](fbcd1d4))
* **Set Node:** Increase search priority
([#7358](#7358))
([e5ad1e7](e5ad1e7))
* **Webhook Node:** Backward compatible form-data parsing for non-array
files ([#7385](#7385))
([6479eb1](6479eb1))


### Features

* **core:** Add Job Summary to Worker response
([#7360](#7360))
([b8608ce](b8608ce))
* **core:** Integrate object store as binary data manager
([#7253](#7253))
([1a661e6](1a661e6))
* **core:** Switch binary filesystem mode to nested path structure
([#7307](#7307))
([0847623](0847623))
* **editor:** Make PDF and Audio binary-data viewable in the UI
([#7367](#7367))
([8187be1](8187be1))
* **editor:** Support autologin for upgrade path
([#7316](#7316))
([1dfa052](1dfa052))
* **Execute Workflow Node:** Run once for each item mode
([#7289](#7289))
([c8c14ca](c8c14ca))
* **Item Lists Node:** Split merge binary data
([#7297](#7297))
([965db8f](965db8f))
* **Loop Over Items (Split in Batches) Node:** Automatically add a loop
+ rename ([#7228](#7228))
([7b773cc](7b773cc))
* **Notion Node:** Fetch child blocks recursively
([#7304](#7304))
([193181a](193181a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 11, 2023

Got released with n8n@1.10.1

elsmr pushed a commit that referenced this pull request Oct 19, 2023
@github-actions @netroy @elsmr
🚀 Release 1.11.0 (#7402)
f10b5f0 
# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0)
(2023-10-11)


### Bug Fixes

* **core:** Add an option to enable postgres ssl with default certs
([#6889](#6889))
([789e1e7](789e1e7))
* **core:** Fix error on missing paired item data
([#7399](#7399))
([47e8953](47e8953))
* **core:** Missing pairing info
([#7326](#7326))
([e2c3c7a](e2c3c7a))
* **core:** Prevent object deletion request on no prefix match
([#7366](#7366))
([63e11e4](63e11e4))
* **editor:** Fix completions for `.json` on quoted node name in Code
node ([#7382](#7382))
([86e7ec7](86e7ec7))
* **editor:** Implement canvas zoom UX improvements
([#7376](#7376))
([7e06b31](7e06b31))
* **editor:** Make workflow history button available only for dev builds
([#7392](#7392))
([7ed466d](7ed466d))
* **editor:** Remove excess margin below run data editor
([#7372](#7372))
([3fa2764](3fa2764))
* **editor:** Sanitize HTML binary-data before rendering in the UI
([#7400](#7400))
([2b075bf](2b075bf))
* **editor:** Use display option's @Version specifier
([#7351](#7351))
([afbf0c3](afbf0c3))
* **Google BigQuery Node:** Location default to jobReference
([#7354](#7354))
([97bb703](97bb703))
* **Google Drive Trigger Node:** Add Shared Drives support
([#7369](#7369))
([3e7a4d3](3e7a4d3))
* **Google Sheets Node:** Fix "Maximum call stack size exceeded" error
on too many rows ([#7384](#7384))
([732b15a](732b15a))
* **HTML Node:** Update property fields to not use expressions on drag
([#7379](#7379))
([77643e5](77643e5))
* **Notion Node:** Handle empty values correctly for Notion selects +
multi selects ([#7383](#7383))
([fbcd1d4](fbcd1d4))
* **Set Node:** Increase search priority
([#7358](#7358))
([e5ad1e7](e5ad1e7))
* **Webhook Node:** Backward compatible form-data parsing for non-array
files ([#7385](#7385))
([6479eb1](6479eb1))


### Features

* **core:** Add Job Summary to Worker response
([#7360](#7360))
([b8608ce](b8608ce))
* **core:** Integrate object store as binary data manager
([#7253](#7253))
([1a661e6](1a661e6))
* **core:** Switch binary filesystem mode to nested path structure
([#7307](#7307))
([0847623](0847623))
* **editor:** Make PDF and Audio binary-data viewable in the UI
([#7367](#7367))
([8187be1](8187be1))
* **editor:** Support autologin for upgrade path
([#7316](#7316))
([1dfa052](1dfa052))
* **Execute Workflow Node:** Run once for each item mode
([#7289](#7289))
([c8c14ca](c8c14ca))
* **Item Lists Node:** Split merge binary data
([#7297](#7297))
([965db8f](965db8f))
* **Loop Over Items (Split in Batches) Node:** Automatically add a loop
+ rename ([#7228](#7228))
([7b773cc](7b773cc))
* **Notion Node:** Fetch child blocks recursively
([#7304](#7304))
([193181a](193181a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-radency michael-radency michael-radency approved these changes

@mutdmour mutdmour mutdmour left review comments

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/new Creation of an entirely new node Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elsmr @janober @mutdmour @michael-radency