fix(Google BigQuery Node): Location default to jobReference #7354

michael-radency · 2023-10-05T08:54:28Z

Github issue / Community forum post (link here to close automatically):

github-actions · 2023-10-05T08:54:47Z

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

If fixing bug, added test to cover scenario.
If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

codecov · 2023-10-05T09:17:27Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ab647b2) 33.43% compared to head (3dba1ff) 33.42%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7354      +/-   ##
==========================================
- Coverage   33.43%   33.42%   -0.01%     
==========================================
  Files        3378     3378              
  Lines      206092   206093       +1     
  Branches    22242    22239       -3     
==========================================
- Hits        68905    68895      -10     
- Misses     136069   136081      +12     
+ Partials     1118     1117       -1

Files	Coverage Δ
...uery/v2/actions/database/executeQuery.operation.ts	`44.00% <75.00%> (+2.10%)`	⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maspio · 2023-10-05T15:26:41Z

packages/nodes-base/nodes/Google/BigQuery/v2/actions/database/executeQuery.operation.ts

@@ -239,7 +240,7 @@ export async function execute(this: IExecuteFunctions): Promise<INodeExecutionDa

 				returnData.push(...prepareOutput.call(this, queryResponse, i, raw, includeSchema));
 			} else {
-				jobs.push({ jobId, projectId, i, raw, includeSchema, location: options.location });
+				jobs.push({ jobId, projectId, i, raw, includeSchema, location });
 			}


location is not actually using the const location from above.

…bigquery-node-location-fix

github-actions · 2023-10-06T09:43:23Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cypress · 2023-10-06T09:43:28Z

Passing run #2407 ↗︎

0	248	0	0	0

Details:

🌳 node-688-bigquery-node-location-fix 🖥️ browsers:node18.12.0-chrome107 🤖 mic...
Project: n8n	Commit: `3dba1ffd9d`
Status: Passed	Duration: 08:18 💡
Started: Oct 6, 2023 11:06 AM	Ended: Oct 6, 2023 11:14 AM

Review all test suite changes for PR #7354 ↗︎

…bigquery-node-location-fix

github-actions · 2023-10-06T10:52:04Z

⚠️ Some Cypress E2E specs are failing, please fix them before merging

github-actions · 2023-10-06T11:14:54Z

✅ All Cypress E2E specs passed

Github issue / Community forum post (link here to close automatically):

@Version

## [1.9.2](https://github.com/n8n-io/n8n/compare/n8n@1.9.1...n8n@1.9.2) (2023-10-09) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([0de6d7d](0de6d7d)) * **editor:** Fix disappearing NDV header in code nodes ([#7290](#7290)) ([7d87392](7d87392)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([8c38984](8c38984)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([73a98cb](73a98cb)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([489a12d](489a12d)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([138d26c](138d26c)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([200fb54](200fb54)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([4517001](4517001)) Co-authored-by: netroy <netroy@users.noreply.github.com>

janober · 2023-10-10T11:40:58Z

Got released with n8n@1.9.3

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

@Version

# [1.11.0](https://github.com/n8n-io/n8n/compare/n8n@1.10.0...n8n@1.11.0) (2023-10-11) ### Bug Fixes * **core:** Add an option to enable postgres ssl with default certs ([#6889](#6889)) ([789e1e7](789e1e7)) * **core:** Fix error on missing paired item data ([#7399](#7399)) ([47e8953](47e8953)) * **core:** Missing pairing info ([#7326](#7326)) ([e2c3c7a](e2c3c7a)) * **core:** Prevent object deletion request on no prefix match ([#7366](#7366)) ([63e11e4](63e11e4)) * **editor:** Fix completions for `.json` on quoted node name in Code node ([#7382](#7382)) ([86e7ec7](86e7ec7)) * **editor:** Implement canvas zoom UX improvements ([#7376](#7376)) ([7e06b31](7e06b31)) * **editor:** Make workflow history button available only for dev builds ([#7392](#7392)) ([7ed466d](7ed466d)) * **editor:** Remove excess margin below run data editor ([#7372](#7372)) ([3fa2764](3fa2764)) * **editor:** Sanitize HTML binary-data before rendering in the UI ([#7400](#7400)) ([2b075bf](2b075bf)) * **editor:** Use display option's @Version specifier ([#7351](#7351)) ([afbf0c3](afbf0c3)) * **Google BigQuery Node:** Location default to jobReference ([#7354](#7354)) ([97bb703](97bb703)) * **Google Drive Trigger Node:** Add Shared Drives support ([#7369](#7369)) ([3e7a4d3](3e7a4d3)) * **Google Sheets Node:** Fix "Maximum call stack size exceeded" error on too many rows ([#7384](#7384)) ([732b15a](732b15a)) * **HTML Node:** Update property fields to not use expressions on drag ([#7379](#7379)) ([77643e5](77643e5)) * **Notion Node:** Handle empty values correctly for Notion selects + multi selects ([#7383](#7383)) ([fbcd1d4](fbcd1d4)) * **Set Node:** Increase search priority ([#7358](#7358)) ([e5ad1e7](e5ad1e7)) * **Webhook Node:** Backward compatible form-data parsing for non-array files ([#7385](#7385)) ([6479eb1](6479eb1)) ### Features * **core:** Add Job Summary to Worker response ([#7360](#7360)) ([b8608ce](b8608ce)) * **core:** Integrate object store as binary data manager ([#7253](#7253)) ([1a661e6](1a661e6)) * **core:** Switch binary filesystem mode to nested path structure ([#7307](#7307)) ([0847623](0847623)) * **editor:** Make PDF and Audio binary-data viewable in the UI ([#7367](#7367)) ([8187be1](8187be1)) * **editor:** Support autologin for upgrade path ([#7316](#7316)) ([1dfa052](1dfa052)) * **Execute Workflow Node:** Run once for each item mode ([#7289](#7289)) ([c8c14ca](c8c14ca)) * **Item Lists Node:** Split merge binary data ([#7297](#7297)) ([965db8f](965db8f)) * **Loop Over Items (Split in Batches) Node:** Automatically add a loop + rename ([#7228](#7228)) ([7b773cc](7b773cc)) * **Notion Node:** Fetch child blocks recursively ([#7304](#7304)) ([193181a](193181a)) Co-authored-by: netroy <netroy@users.noreply.github.com>

⚡ fix

a7bcf7b

michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Oct 5, 2023

maspio reviewed Oct 5, 2023

View reviewed changes

michael-radency added 2 commits October 5, 2023 20:51

⚡ location var fix

9b7cdd7

Merge branch 'master' of https://github.com/n8n-io/n8n into node-688-…

64b70ab

…bigquery-node-location-fix

maspio approved these changes Oct 6, 2023

View reviewed changes

Merge branch 'master' of https://github.com/n8n-io/n8n into node-688-…

3dba1ff

…bigquery-node-location-fix

maspio approved these changes Oct 6, 2023

View reviewed changes

michael-radency merged commit 97bb703 into master Oct 6, 2023
55 checks passed

michael-radency deleted the node-688-bigquery-node-location-fix branch October 6, 2023 11:16

netroy pushed a commit that referenced this pull request Oct 9, 2023

fix(Google BigQuery Node): Location default to jobReference (#7354)

489a12d

Github issue / Community forum post (link here to close automatically):

github-actions bot mentioned this pull request Oct 9, 2023

🚀 Release 1.9.2 #7387

Merged

janober added the Released label Oct 10, 2023

github-actions bot mentioned this pull request Oct 11, 2023

🚀 Release 1.11.0 #7402

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Google BigQuery Node): Location default to jobReference #7354

fix(Google BigQuery Node): Location default to jobReference #7354

michael-radency commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading

maspio Oct 5, 2023

github-actions bot commented Oct 6, 2023

cypress bot commented Oct 6, 2023 •

edited

Loading

github-actions bot commented Oct 6, 2023

github-actions bot commented Oct 6, 2023

janober commented Oct 10, 2023

fix(Google BigQuery Node): Location default to jobReference #7354

fix(Google BigQuery Node): Location default to jobReference #7354

Conversation

michael-radency commented Oct 5, 2023

github-actions bot commented Oct 5, 2023

codecov bot commented Oct 5, 2023 • edited Loading

Codecov Report

maspio Oct 5, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 6, 2023

cypress bot commented Oct 6, 2023 • edited Loading

Passing run #2407 ↗︎

Review all test suite changes for PR #7354 ↗︎

github-actions bot commented Oct 6, 2023

github-actions bot commented Oct 6, 2023

janober commented Oct 10, 2023

codecov bot commented Oct 5, 2023 •

edited

Loading

cypress bot commented Oct 6, 2023 •

edited

Loading