refactor(core): Make workflow services injectable (no-changelog) #8033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
requested changes
Dec 15, 2023
netroy
requested changes
Dec 15, 2023
|
Thanks! I should've seen the others. |
netroy
requested changes
Dec 15, 2023
netroy
reviewed
Dec 15, 2023
netroy
approved these changes
Dec 15, 2023
1 flaky test on run #3351 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Screenshots
Video
|
|
Review all test suite changes for PR #8033 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 15, 2023
* master: fix(editor): Cleanup Executions page component (#8053) feat: Add config option to prefer GET request over LIST when using Hashicorp Vault (#8049) fix(HTTP Request Node): Do not create circular references in HTTP request node output (#8030) fix(core): Handle multiple termination signals correctly (#8046) fix(core): Close db connection gracefully when exiting (#8045) fix(core): Public API support node's deprecated continueOnFail to upload old workflows (no-changelog) (#8044) fix(core): Remove circular references before serializing executions in public API (#8043) refactor(core): Make workflow services injectable (no-changelog) (#8033) refactor(core): Remove ID-less workflow reporting (no-changelog) (#8038) feat(Filter Node): Overhaul UI by adding the new filter component (#8016)
ivov
added a commit
that referenced
this pull request
Dec 18, 2023
…log) (#8066) Inject dependencies into workflow services (no-changelog) Up next: - ~~Make workflow services injectable~~ #8033 - ~~Inject dependencies into workflow services~~ (current) - Consolidate workflow controllers into one - Make workflow controller injectable - Inject dependencies into workflow controller
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor static workflow service classes into DI-compatible classes
Context: https://n8nio.slack.com/archives/C069HS026UF/p1702466571648889
Up next: