Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Remove ID-less workflow reporting (no-changelog) #8038

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Dec 15, 2023

We added ID-less workflow reporting at #8031, which has already produced multiple reports coming from internal, enough info to tackle this story. To prevent an overwhelming number of reports from cloud, this PR removes the reporting for now.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 15, 2023
Copy link

cypress bot commented Dec 15, 2023

Passing run #3350 ↗︎

0 305 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: f57563284e
Status: Passed Duration: 06:29 💡
Started: Dec 15, 2023 11:39 AM Ended: Dec 15, 2023 11:46 AM

Review all test suite changes for PR #8038 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 2da15d0 into master Dec 15, 2023
19 checks passed
@ivov ivov deleted the remove-id-less-workflow-reporting branch December 15, 2023 11:50
ivov added a commit that referenced this pull request Dec 15, 2023
We added ID-less workflow reporting at #8031, which has already produced
multiple reports coming from internal, enough info to tackle [this
story](https://linear.app/n8n/issue/PAY-1147). To prevent an
overwhelming number of reports from cloud, this PR removes the reporting
for now.
@janober
Copy link
Member

janober commented Dec 15, 2023

Got released with n8n@1.21.1

MiloradFilipovic added a commit that referenced this pull request Dec 15, 2023
* master:
  fix(editor): Cleanup Executions page component (#8053)
  feat: Add config option to prefer GET request over LIST when using Hashicorp Vault (#8049)
  fix(HTTP Request Node): Do not create circular references in HTTP request node output (#8030)
  fix(core): Handle multiple termination signals correctly (#8046)
  fix(core): Close db connection gracefully when exiting (#8045)
  fix(core): Public API support node's deprecated continueOnFail to upload old workflows (no-changelog) (#8044)
  fix(core): Remove circular references before serializing executions in public API (#8043)
  refactor(core): Make workflow services injectable (no-changelog) (#8033)
  refactor(core): Remove ID-less workflow reporting (no-changelog) (#8038)
  feat(Filter Node): Overhaul UI by adding the new filter component (#8016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants