Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Chrome Canary #18

Closed
JeremyRand opened this issue Aug 29, 2017 · 0 comments
Closed

Support Chrome Canary #18

JeremyRand opened this issue Aug 29, 2017 · 0 comments

Comments

@JeremyRand
Copy link
Member

Chrome Canary has its own User Data folder, separate from Chromium and Chrome. According to https://chromium.googlesource.com/chromium/src/+/master/docs/user_data_dir.md , Chrome Canary's User Data folder on Windows is %LOCALAPPDATA%\Google\Chrome SxS\User Data. As with Chromium and Chrome, multiple profiles can exist inside that folder.
hlandau added a commit to hlandauf/ncdns-nsis that referenced this issue Sep 1, 2017
@hlandau
Add Chromium multi-profile support, Canary support
34d071e 
Fixes namecoin#17.
Fixes namecoin#18.

©! I, Hugo Landau <hlandau@devever.net>, hereby licence these changes under the
©! licence with SHA256 hash
©! fd80a26fbb3f644af1fa994134446702932968519797227e07a1368dea80f0bc.
@hlandau hlandau mentioned this issue Sep 1, 2017
Merged
JeremyRand added a commit that referenced this issue Sep 3, 2017
@JeremyRand
Merge #20: Add Chromium multi-profile support, Canary support
e957a78 
34d071e Add Chromium multi-profile support, Canary support (Hugo Landau)

Pull request description:

  Fixes #17.
  Fixes #18.

  This works by just trying to treat all subdirectories of a Chromium workspace as profile directories potentially containing a TransportSecurity file. It's slightly hackish, but works well given that the naming of profile directories seems a bit haphazard, and if we encounter any TransportSecurity files under a Chromium workspace we surely want to process them, largely regardless of the context.

Tree-SHA512: bf3ddd8f993eb26589584e5841f068fe2719b9d258df5b254b2083cc82b910fd1203f5fb8f039ce1a0775dd23c0935e0369a6d45fb128ae4ebf0bc1b62fbcc88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand