Skip to content

Conversation

psobolewskiPhD
Copy link
Member

Description

In napari/napari#5848 @dalthviz found a bug with a 3D mode GUI feature (perspective slider) that isn't documented—i didn't even know it existed, let alone that it was bugged. Additionally, I noted that the docs only cover drag to rotate the view, not shift-drag to move.
This PR updates the viewer tutorial to mention these two aspects.

Depends on napari/napari#5848
(because the perspective bit is currently bugged, lets make sure the fix is merged before we merge this)

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

References

The perspective slider was implemented here: napari/napari#2636

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 20, 2023
@psobolewskiPhD psobolewskiPhD added enhancement New feature or request content Ideas for new or improved content and removed documentation Improvements or additions to documentation labels May 20, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 20, 2023
@psobolewskiPhD psobolewskiPhD requested a review from melissawm May 21, 2023 16:37
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @psobolewskiPhD !

@psobolewskiPhD psobolewskiPhD requested a review from brisvag May 22, 2023 16:29
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick, but overall looks good, thanks!

Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
@psobolewskiPhD
Copy link
Member Author

Oh oh, seeing an error in the CircleCi preview:
https://output.circle-artifacts.com/output/job/9bd40329-d940-4772-acbf-52cc1caa393a/artifacts/0/docs/_build/tutorials/fundamentals/viewer.html#toggle-ndisplay-2d-3d-button
But when I download the docs artifact it looks fine:
image

@psobolewskiPhD psobolewskiPhD merged commit b56f295 into napari:main Jun 9, 2023
@psobolewskiPhD psobolewskiPhD deleted the 3d_viewer_addendum branch June 9, 2023 11:49
@psobolewskiPhD psobolewskiPhD added this to the 0.4.18 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Ideas for new or improved content documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants